Skip to content

Commit fedc39a

Browse files
committed
PR feedback - rename indexid to indices
1 parent 2f1005f commit fedc39a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/traces/pointcloud/attributes.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ module.exports = {
2121
'represents points such that `xy[i * 2] = x[i]` and `xy[i * 2 + 1] = y[i]`'
2222
].join(' ')
2323
},
24-
indexid: {
24+
indices: {
2525
valType: 'data_array',
2626
description: [
2727
'A sequential value, 0..n, supply it to avoid creating this array inside plotting.',
2828
'Its length must be equal to or greater than the number of points.',
29-
'For the best performance and memory use, create one large `indexid` typed array',
29+
'For the best performance and memory use, create one large `indices` typed array',
3030
'that is guaranteed to be at least as long as the largest number of points during',
3131
'use, and reuse it on each `Plotly.restyle()` call.'
3232
].join(' ')

src/traces/pointcloud/convert.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ proto.updateFast = function(options) {
8484

8585
var xy = options.xy;
8686
var userBounds = options.bounds;
87-
var index = options.indexid;
87+
var index = options.indices;
8888

8989
var len = x.length,
9090
idToIndex,

src/traces/pointcloud/defaults.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor) {
2626
traceOut.xy = traceIn.xy;
2727
}
2828

29-
if(traceIn.indexid && traceIn.indexid instanceof Int32Array) {
30-
traceOut.indexid = traceIn.indexid;
29+
if(traceIn.indices && traceIn.indices instanceof Int32Array) {
30+
traceOut.indices = traceIn.indices;
3131
}
3232

3333
coerce('text');

0 commit comments

Comments
 (0)