Skip to content

Commit fad8fde

Browse files
authored
Merge pull request #6443 from plotly/sync-tickmode-fix-noci
Avoid extra redraw calls when updating axes with `tickmode` other than sync
2 parents 360213e + 0828681 commit fad8fde

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

draftlogs/6356_add.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
- Add `sync` tickmode option [[#6356](https://github.com/plotly/plotly.js/pull/6356)]
1+
- Add `sync` tickmode option [[#6356](https://github.com/plotly/plotly.js/pull/6356), [#6443](https://github.com/plotly/plotly.js/pull/6443)]

src/plots/cartesian/dragbox.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,9 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
729729

730730
function pushActiveAxIdsSynced(axList, axisType) {
731731
for(i = 0; i < axList.length; i++) {
732-
if(!axList[i].fixedrange && axList[i][axisType]) {activeAxIds.push(axList[i][axisType]._id);}
732+
var axListI = axList[i];
733+
var axListIType = axListI[axisType];
734+
if(!axListI.fixedrange && axListIType.tickmode === 'sync') activeAxIds.push(axListIType._id);
733735
}
734736
}
735737

0 commit comments

Comments
 (0)