🔪 colorbar.vals - seems like that was all obsolete anyway

Author: alexcjohnson

src/components/colorbar/connect.js

@@ -9,9 +9,6 @@
 
 'use strict';
 
-var isNumeric = require('fast-isnumeric');
-
-var aggNums = require('../../lib').aggNums;
 var Colorscale = require('../colorscale');
 var drawColorbar = require('./draw');
 
@@ -54,21 +51,6 @@ module.exports = function connectColorbar(gd, cd, moduleOpts) {
     var zmin = container[moduleOpts.min];
     var zmax = container[moduleOpts.max];
 
-    var valAttr = moduleOpts.vals;
-    var vals;
-    if(Array.isArray(valAttr)) {
-        for(var i = 0; i < valAttr.length; i++) {
-            vals = container[valAttr[i]];
-            if(vals) break;
-        }
-    }
-    else vals = container[valAttr];
-
-    if(vals) {
-        if(!isNumeric(zmin)) zmin = aggNums(Math.min, null, vals);
-        if(!isNumeric(zmax)) zmax = aggNums(Math.max, null, vals);
-    }
-
     var cb = cd[0].t.cb = drawColorbar(gd, cbId);
     var sclFunc = Colorscale.makeColorScaleFunc(
         Colorscale.extractScale(

src/traces/cone/index.js

@@ -19,7 +19,6 @@ module.exports = {
     colorbar: {
         min: 'cmin',
         max: 'cmax'
-        // no vals, these are calculated automatically from vector norms
     },
     calc: require('./calc'),
     plot: require('./convert'),

src/traces/heatmap/colorbar.js

@@ -10,6 +10,5 @@
 
 module.exports = {
     min: 'zmin',
-    max: 'zmax',
-    vals: 'z'
+    max: 'zmax'
 };

src/traces/mesh3d/index.js

@@ -16,8 +16,7 @@ Mesh3D.supplyDefaults = require('./defaults');
 Mesh3D.calc = require('./calc');
 Mesh3D.colorbar = {
     min: 'cmin',
-    max: 'cmax',
-    vals: 'intensity'
+    max: 'cmax'
 };
 Mesh3D.plot = require('./convert');
 

src/traces/parcoords/index.js

@@ -17,8 +17,7 @@ Parcoords.plot = require('./plot');
 Parcoords.colorbar = {
     container: 'line',
     min: 'cmin',
-    max: 'cmax',
-    vals: 'color'
+    max: 'cmax'
 };
 
 Parcoords.moduleType = 'trace';

src/traces/scatter/marker_colorbar.js

@@ -12,6 +12,5 @@
 module.exports = {
     container: 'marker',
     min: 'cmin',
-    max: 'cmax',
-    vals: 'color'
+    max: 'cmax'
 };

src/traces/surface/index.js

@@ -15,8 +15,7 @@ Surface.attributes = require('./attributes');
 Surface.supplyDefaults = require('./defaults');
 Surface.colorbar = {
     min: 'cmin',
-    max: 'cmax',
-    vals: ['surfacecolor', 'z']
+    max: 'cmax'
 };
 Surface.calc = require('./calc');
 Surface.plot = require('./convert');