Skip to content

Commit f824902

Browse files
committed
delete empty rangebreaks and tickformatstops after coerce container
1 parent 2494c4e commit f824902

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

src/plots/cartesian/axis_defaults.js

+9-8
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,15 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
126126
}
127127

128128
if(axType === 'date') {
129-
var rangebreaks = containerIn.rangebreaks || axTemplate.rangebreaks;
130-
131-
if(Array.isArray(rangebreaks) && rangebreaks.length) {
132-
handleArrayContainerDefaults(containerIn, containerOut, {
133-
name: 'rangebreaks',
134-
inclusionAttr: 'enabled',
135-
handleItemDefaults: rangebreaksDefaults
136-
});
129+
handleArrayContainerDefaults(containerIn, containerOut, {
130+
name: 'rangebreaks',
131+
inclusionAttr: 'enabled',
132+
handleItemDefaults: rangebreaksDefaults
133+
});
134+
135+
if(!containerOut.rangebreaks.length) {
136+
delete containerOut.rangebreaks;
137+
} else {
137138
setConvert(containerOut, layoutOut);
138139

139140
if(layoutOut._has('scattergl') || layoutOut._has('splom')) {

src/plots/cartesian/tick_label_defaults.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,15 @@ function handleOtherDefaults(containerIn, containerOut, coerce, axType, options)
6060
if(axType !== 'category') {
6161
var tickFormat = coerce('tickformat');
6262

63-
var axTemplate = containerOut._template || {};
64-
var tickformatStops = containerIn.tickformatstops || axTemplate.tickformatstops;
65-
66-
if(Array.isArray(tickformatStops) && tickformatStops.length) {
67-
handleArrayContainerDefaults(containerIn, containerOut, {
68-
name: 'tickformatstops',
69-
inclusionAttr: 'enabled',
70-
handleItemDefaults: tickformatstopDefaults
71-
});
63+
handleArrayContainerDefaults(containerIn, containerOut, {
64+
name: 'tickformatstops',
65+
inclusionAttr: 'enabled',
66+
handleItemDefaults: tickformatstopDefaults
67+
});
68+
if(!containerOut.tickformatstops.length) {
69+
delete containerOut.tickformatstops;
7270
}
71+
7372
if(!tickFormat && axType !== 'date') {
7473
coerce('showexponent', showAttrDflt);
7574
coerce('exponentformat');

0 commit comments

Comments
 (0)