Skip to content

Commit f256361

Browse files
committed
mesh3d document update - review feedback
1 parent dfd29d4 commit f256361

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

src/traces/mesh3d/attributes.js

+10-14
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = {
3131
z: {
3232
valType: 'data_array',
3333
description: [
34-
'Sets the X coordinates of the vertices. The nth element of vectors `x`, `y` and `z`',
34+
'Sets the Z coordinates of the vertices. The nth element of vectors `x`, `y` and `z`',
3535
'jointly represent the X, Y and Z coordinates of the nth vertex.'
3636
].join(' ')
3737
},
@@ -42,7 +42,7 @@ module.exports = {
4242
'A vector of vertex indices, i.e. integer values between 0 and the length of the vertex',
4343
'vectors, representing the *first* vertex of a triangle. For example, `{i[m], j[m], k[m]}`',
4444
'together represent face m (triangle m) in the mesh, where `i[m] = n` points to the triplet',
45-
'`{x[n], y[n], z[v]}` in the vertex arrays. Therefore, each element in `i` represents a',
45+
'`{x[n], y[n], z[n]}` in the vertex arrays. Therefore, each element in `i` represents a',
4646
'point in space, which is the first vertex of a triangle.'
4747
].join(' ')
4848
},
@@ -52,7 +52,7 @@ module.exports = {
5252
'A vector of vertex indices, i.e. integer values between 0 and the length of the vertex',
5353
'vectors, representing the *second* vertex of a triangle. For example, `{i[m], j[m], k[m]}` ',
5454
'together represent face m (triangle m) in the mesh, where `j[m] = n` points to the triplet',
55-
'`{x[n], y[n], z[v]}` in the vertex arrays. Therefore, each element in `j` represents a',
55+
'`{x[n], y[n], z[n]}` in the vertex arrays. Therefore, each element in `j` represents a',
5656
'point in space, which is the second vertex of a triangle.'
5757
].join(' ')
5858

@@ -63,7 +63,7 @@ module.exports = {
6363
'A vector of vertex indices, i.e. integer values between 0 and the length of the vertex',
6464
'vectors, representing the *third* vertex of a triangle. For example, `{i[m], j[m], k[m]}`',
6565
'together represent face m (triangle m) in the mesh, where `k[m] = n` points to the triplet ',
66-
'`{x[n], y[n], z[v]}` in the vertex arrays. Therefore, each element in `k` represents a',
66+
'`{x[n], y[n], z[n]}` in the vertex arrays. Therefore, each element in `k` represents a',
6767
'point in space, which is the third vertex of a triangle.'
6868
].join(' ')
6969

@@ -91,24 +91,20 @@ module.exports = {
9191
'vertices (points) represented by the `x`, `y` and `z` arrays, if',
9292
'the `i`, `j`, `k` arrays are not supplied.',
9393
'For general use of `mesh3d` it is preferred that `i`, `j`, `k` are',
94-
'supplied, because calculating the surface from points can be very',
95-
'time consuming and usually lead to artifacts.',
94+
'supplied.',
9695

9796
'If *-1*, Delaunay triangulation is used, which is mainly suitable if the',
9897
'mesh is a single, more or less layer surface that is perpendicular to `delaunayaxis`.',
9998
'In case the `delaunayaxis` intersects the mesh surface at more than one point',
100-
'(e.g. sphere, cube, potato, animal, donut etc. shapes) it will lead to triangles',
101-
'that are very long in the dimension of `delaunayaxis`.',
99+
'it will result triangles that are very long in the dimension of `delaunayaxis`.',
102100

103-
'If *>0*, the alpha-shape algorithm is used. In this case, the `alphahull` value',
104-
'not only signals the intention to choose the alpha-shape algorithm, but its value',
105-
'acts as the parameter for the mesh fitting. It can take minutes to calculate a large',
106-
'mesh (e.g. over 10 thousand points), and the result is very sensitive to the',
107-
'chosen value. ',
101+
'If *>0*, the alpha-shape algorithm is used. In this case, the positive `alphahull` value',
102+
'signals the use of the alpha-shape algorithm, _and_ its value',
103+
'acts as the parameter for the mesh fitting.',
108104

109105
'If *0*, the convex-hull algorithm is used. It is suitable for convex bodies',
110106
'or if the intention is to enclose the `x`, `y` and `z` point set into a convex',
111-
'hull. However it can not generate concave surfaces.'
107+
'hull.'
112108
].join(' ')
113109
},
114110

0 commit comments

Comments
 (0)