Skip to content

Commit ef6a952

Browse files
committed
add comment about special logic to consider values colorscales in sunburst and treemap
1 parent f6b91e8 commit ef6a952

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/traces/sunburst/defaults.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
4444
if(lineWidth) coerce('marker.line.color', layout.paper_bgcolor);
4545

4646
coerce('marker.colors');
47-
var withColorscale = traceOut._hasColorscale = (traceIn.marker || {}).coloraxis || hasColorscale(traceIn, 'marker', 'colors');
47+
var withColorscale = traceOut._hasColorscale = (
48+
hasColorscale(traceIn, 'marker', 'colors') ||
49+
(traceIn.marker || {}).coloraxis // N.B. special logic to consider "values" colorscales
50+
);
4851
if(withColorscale) {
4952
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'});
5053
}

src/traces/treemap/defaults.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
7373
if(lineWidth) coerce('marker.line.color', layout.paper_bgcolor);
7474

7575
var colors = coerce('marker.colors');
76-
var withColorscale = traceOut._hasColorscale = (traceIn.marker || {}).coloraxis || hasColorscale(traceIn, 'marker', 'colors');
76+
var withColorscale = traceOut._hasColorscale = (
77+
hasColorscale(traceIn, 'marker', 'colors') ||
78+
(traceIn.marker || {}).coloraxis // N.B. special logic to consider "values" colorscales
79+
);
7780
if(withColorscale) {
7881
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'});
7982
} else {

0 commit comments

Comments
 (0)