Skip to content

Commit eaf1384

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md
1 parent 7f6650b commit eaf1384

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,13 @@ Thanks for your interest in plotly.js!
88
- You should only update files in `lib/locales/`, not those in `dist/`
99

1010
### Features, Bug fixes, and others:
11-
12-
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
13-
1411
Before opening a pull request, developer should:
1512

1613
- `git rebase` their local branch off the latest `master`,
1714
- make sure to **not** `git add` the `dist/` folder (the `dist/` is updated only on version bumps),
18-
- make sure to commit changes to the `package-lock.json` file (if any),
15+
- make sure to commit changes to the `package-lock.json` file (if any new dependency required),
1916
- write an overview of what the PR attempts to do,
17+
- make a PR directly from their fork to the main repository i.e. plotly/plotly.js
2018
- select the _Allow edits from maintainers_ option (see this [article](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for more details).
2119

2220
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please `git merge master` into your PR branch instead of `git rebase master`.

0 commit comments

Comments
 (0)