Skip to content

Commit e79af84

Browse files
committed
parcoords refactor - rename glLayers
1 parent 5c5873d commit e79af84

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/traces/parcoords/parcoords.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
417417
return Lib.extendFlat(d, vm[i]);
418418
});
419419

420-
var parcoordsLineLayer = glContainer.selectAll('.gl-canvas')
420+
var glLayers = glContainer.selectAll('.gl-canvas')
421421
.each(function(d) {
422422
// FIXME: figure out how to handle multiple instances
423423
d.viewModel = vm[0];
@@ -426,7 +426,7 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
426426

427427
var lastHovered = null;
428428

429-
var pickLayer = parcoordsLineLayer.filter(function(d) {return d.pick;});
429+
var pickLayer = glLayers.filter(function(d) {return d.pick;});
430430

431431
// emit hover / unhover event
432432
pickLayer
@@ -466,26 +466,26 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
466466
}
467467
});
468468

469-
parcoordsLineLayer
469+
glLayers
470470
.style('opacity', function(d) {return d.pick ? 0.01 : 1;});
471471

472472
svg.style('background', 'rgba(255, 255, 255, 0)');
473-
var parcoordsControlOverlay = svg.selectAll('.' + c.cn.parcoords)
473+
var controlOverlay = svg.selectAll('.' + c.cn.parcoords)
474474
.data(vm, keyFun);
475475

476-
parcoordsControlOverlay.exit().remove();
476+
controlOverlay.exit().remove();
477477

478-
parcoordsControlOverlay.enter()
478+
controlOverlay.enter()
479479
.append('g')
480480
.classed(c.cn.parcoords, true)
481481
.style('shape-rendering', 'crispEdges')
482482
.style('pointer-events', 'none');
483483

484-
parcoordsControlOverlay.attr('transform', function(d) {
484+
controlOverlay.attr('transform', function(d) {
485485
return 'translate(' + d.model.translateX + ',' + d.model.translateY + ')';
486486
});
487487

488-
var parcoordsControlView = parcoordsControlOverlay.selectAll('.' + c.cn.parcoordsControlView)
488+
var parcoordsControlView = controlOverlay.selectAll('.' + c.cn.parcoordsControlView)
489489
.data(repeat, keyFun);
490490

491491
parcoordsControlView.enter()
@@ -507,7 +507,7 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
507507
updatePanelLayout(yAxis, vm);
508508
});
509509

510-
parcoordsLineLayer
510+
glLayers
511511
.each(function(d) {
512512
if(d.viewModel) {
513513
if(!d.lineLayer || callbacks) { // recreate in case of having callbacks e.g. restyle. Should we test for callback to be a restyle?

0 commit comments

Comments
 (0)