Skip to content

Commit e66b508

Browse files
committed
bring scatterpolargl axis expansion on-par with scatterpolar
1 parent 4b6cf3d commit e66b508

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

src/traces/scatterpolargl/index.js

+10-5
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ var isNumeric = require('fast-isnumeric');
1313

1414
var ScatterGl = require('../scattergl');
1515
var calcColorscales = require('../scatter/colorscale_calc');
16+
var calcMarkerSize = require('../scatter/calc').calcMarkerSize;
1617
var Axes = require('../../plots/cartesian/axes');
1718
var makeHoverPointText = require('../scatterpolar/hover').makeHoverPointText;
1819
var subTypes = require('../scatter/subtypes');
@@ -26,17 +27,21 @@ function calc(container, trace) {
2627
var angularAxis = layout[subplotId].angularaxis;
2728
var rArray = radialAxis.makeCalcdata(trace, 'r');
2829
var thetaArray = angularAxis.makeCalcdata(trace, 'theta');
30+
var len = trace._length;
2931
var stash = {};
3032

31-
if(trace._length < rArray.length) rArray = rArray.slice(0, trace._length);
32-
if(trace._length < thetaArray.length) thetaArray = thetaArray.slice(0, trace._length);
33-
34-
calcColorscales(trace);
33+
if(len < rArray.length) rArray = rArray.slice(0, len);
34+
if(len < thetaArray.length) thetaArray = thetaArray.slice(0, len);
3535

3636
stash.r = rArray;
3737
stash.theta = thetaArray;
3838

39-
trace._extremes.x = Axes.findExtremes(radialAxis, rArray, {tozero: true});
39+
// We could add TOO_MANY_POINTS logic like in Scattergl.calc,
40+
// if users asks for scaterpolargl charts with > 1e5 pts
41+
var ppad = calcMarkerSize(trace, len);
42+
trace._extremes.x = Axes.findExtremes(radialAxis, rArray, {ppad: ppad});
43+
44+
calcColorscales(trace);
4045

4146
return [{x: false, y: false, t: stash, trace: trace}];
4247
}
-6.02 KB
Loading
4.29 KB
Loading
49 Bytes
Loading
2.97 KB
Loading

0 commit comments

Comments
 (0)