mojtaba-proof a few things

- move isNonBlankString in outer scope
- add "" around URL in invalid-url error msg

Author: etpinard

src/plots/mapbox/mapbox.js

@@ -142,7 +142,7 @@ proto.fetchMapData = function(calcData) {
                 if(err) {
                     delete PlotlyGeoAssets[url];
                     var msg = err.status === 404 ?
-                        ('GeoJSON at URL ' + url + ' does not exist.') :
+                        ('GeoJSON at URL "' + url + '" does not exist.') :
                         ('Unexpected error while fetching from ' + url);
                     return reject(new Error(msg));
                 }

src/traces/choropleth/calc.js

@@ -15,11 +15,14 @@ var colorscaleCalc = require('../../components/colorscale/calc');
 var arraysToCalcdata = require('../scatter/arrays_to_calcdata');
 var calcSelection = require('../scatter/calc_selection');
 
+function isNonBlankString(v) {
+    return v && typeof v === 'string';
+}
+
 module.exports = function calc(gd, trace) {
     var len = trace._length;
     var calcTrace = new Array(len);
 
-    var isNonBlankString = function(v) { return v && typeof v === 'string'; };
     var isValidLoc;
 
     if(trace.geojson) {

test/jasmine/tests/mapbox_test.js

@@ -1351,7 +1351,7 @@ describe('@noCI Test mapbox GeoJSON fetching:', function() {
             actual = reason;
         })
         .then(function() {
-            expect(actual).toEqual(new Error('GeoJSON at URL invalidUrl does not exist.'));
+            expect(actual).toEqual(new Error('GeoJSON at URL "invalidUrl" does not exist.'));
             expect(window.PlotlyGeoAssets.invalidUrl).toBe(undefined);
         })
         .then(done);