Skip to content

Commit e501b96

Browse files
committed
switched to proper Plotly Lib.extend
1 parent 61b3baf commit e501b96

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

src/traces/parcoords/parcoords.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
var lineLayerMaker = require('./lines');
1212
var utils = require('./utils');
13+
var Lib = require('../../lib');
1314
var d3 = require('d3');
1415

1516
function keyFun(d) {
@@ -116,7 +117,7 @@ module.exports = function(root, styledData, layout) {
116117
var tickDistance = styledData.tickdistance;
117118
var coloringDomainToUnitScale = makeDomainToUnitScale(styledData.line.color);
118119
var overdrag = 40;
119-
var lines = utils.extend(styledData.lines, {
120+
var lines = Lib.extendDeep(styledData.lines, {
120121
color: styledData.line.color.map(coloringDomainToUnitScale),
121122
overdrag: overdrag
122123
});

src/traces/parcoords/utils.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,6 @@ module.exports = (function() {
121121

122122
range: range,
123123

124-
extend: function extend(object, props) {
125-
// this is a simple placeholder for a proper `extend` supplied by
126-
// comprehensive library utilities
127-
return Object.create(object, Object.getOwnPropertyDescriptors(props));
128-
},
129-
130124
d3OrdinalScaleSnap: function closestValue(scale, v) {
131125
var i, a, prevDiff, prevValue, diff;
132126
for(i = 0, a = scale.range(), prevDiff = Infinity, prevValue = a[0], diff; i < a.length; i++) {

0 commit comments

Comments
 (0)