Skip to content

Commit e32b60f

Browse files
committed
findArrayAttributes: include array attribute in fullInput module
- this may have some side effects, but this is necessary to make ohlc and candlestick work with filter and groupby transforms - in brief, we need to make sure 'data_array' of input module are used correctly during filter and groupby operations
1 parent 96e129a commit e32b60f

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/lib/coerce.js

+9
Original file line numberDiff line numberDiff line change
@@ -457,5 +457,14 @@ exports.findArrayAttributes = function(trace) {
457457

458458
exports.crawl(trace._module.attributes, callback);
459459

460+
// TODO add comment
461+
if(trace._fullInput) {
462+
exports.crawl(trace._fullInput._module.attributes, callback);
463+
464+
arrayAttributes = arrayAttributes.filter(function(g, i, self) {
465+
return self.indexOf(g) === i;
466+
});
467+
}
468+
460469
return arrayAttributes;
461470
};

0 commit comments

Comments
 (0)