Skip to content

Commit e1ac9d7

Browse files
committed
improved coerce behavior
1 parent ba780f9 commit e1ac9d7

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/components/shapes/defaults.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,9 @@ function handleShapeDefaults(shapeIn, shapeOut, fullLayout) {
128128

129129
// Label options
130130
var isLine = shapeType === 'line';
131-
var labelText = coerce('label.text');
132-
var labelTextTemplate = coerce('label.texttemplate');
131+
var labelTextTemplate, labelText;
132+
if(noPath) { labelTextTemplate = coerce('label.texttemplate'); }
133+
if(!labelTextTemplate) { labelText = coerce('label.text'); }
133134
if(labelText || labelTextTemplate) {
134135
coerce('label.textangle');
135136
var labelTextPosition = coerce('label.textposition', isLine ? 'middle' : 'middle center');

src/components/shapes/draw.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -611,21 +611,23 @@ function drawLabel(gd, index, options, shapeGroup) {
611611
if(!(options.label.text || options.label.texttemplate)) return;
612612

613613
// Text template overrides text
614-
var text = options.label.text;
614+
var text;
615615
if(options.label.texttemplate) {
616616
var templateValues = {};
617617
if(options.type !== 'path') {
618618
var _xa = Axes.getFromId(gd, options.xref);
619619
var _ya = Axes.getFromId(gd, options.yref);
620-
Object.keys(shapeLabelTexttemplateVars).forEach(function(key) {
620+
for(var key in shapeLabelTexttemplateVars) {
621621
var val = shapeLabelTexttemplateVars[key](options, _xa, _ya);
622622
if(val !== undefined) templateValues[key] = val;
623-
});
623+
}
624624
}
625625
text = Lib.texttemplateStringForShapes(options.label.texttemplate,
626626
{},
627627
gd._fullLayout._d3locale,
628628
templateValues);
629+
} else {
630+
text = options.label.text;
629631
}
630632

631633
var labelGroupAttrs = {

0 commit comments

Comments
 (0)