Skip to content

Commit e08e37a

Browse files
committed
simplify sankey hover events
1 parent 5d0f3e2 commit e08e37a

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

src/components/fx/hover.js

-8
Original file line numberDiff line numberDiff line change
@@ -155,14 +155,6 @@ exports.loneHover = function loneHover(hoverItem, opts) {
155155

156156
// The actual implementation is here:
157157
function _hover(gd, evt, subplot, noHoverEvent) {
158-
if(subplot === 'sankey' && !noHoverEvent) {
159-
gd.emit('plotly_hover', {
160-
event: evt.originalEvent,
161-
points: [evt]
162-
});
163-
return;
164-
}
165-
166158
if(!subplot) subplot = 'xy';
167159

168160
// if the user passed in an array of subplots,

src/traces/sankey/plot.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,11 @@ module.exports = function plot(gd, calcData) {
128128
};
129129

130130
var linkHover = function(element, d, sankey) {
131-
var evt = d.link;
132-
evt.originalEvent = d3.event;
133131
d3.select(element).call(linkHoveredStyle.bind(0, d, sankey, true));
134-
Fx.hover(gd, evt, 'sankey');
132+
gd.emit('plotly_hover', {
133+
event: d3.event,
134+
points: [d.link]
135+
});
135136
};
136137

137138
var linkHoverFollow = function(element, d) {
@@ -185,10 +186,11 @@ module.exports = function plot(gd, calcData) {
185186
};
186187

187188
var nodeHover = function(element, d, sankey) {
188-
var evt = d.node;
189-
evt.originalEvent = d3.event;
190189
d3.select(element).call(nodeHoveredStyle, d, sankey);
191-
Fx.hover(gd, evt, 'sankey');
190+
gd.emit('plotly_hover', {
191+
event: d3.event,
192+
points: [d.node]
193+
});
192194
};
193195

194196
var nodeHoverFollow = function(element, d) {

0 commit comments

Comments
 (0)