move selection code into components/selections

Author: archmoj

src/components/selections/constants.js

@@ -0,0 +1,15 @@
+'use strict';
+
+module.exports = {
+    // max pixels off straight before a lasso select line counts as bent
+    BENDPX: 1.5,
+
+    // smallest dimension allowed for a select box
+    MINSELECT: 12,
+
+    // throttling limit (ms) for selectPoints calls
+    SELECTDELAY: 100,
+
+    // cache ID suffix for throttle
+    SELECTID: '-select',
+};

src/plots/cartesian/handle_outline.js renamed to src/components/selections/handle_outline.js

@@ -3,25 +3,25 @@
 var polybool = require('polybooljs');
 
 var Registry = require('../../registry');
-var dashStyle = require('../../components/drawing').dashStyle;
-var Color = require('../../components/color');
-var Fx = require('../../components/fx');
-var makeEventData = require('../../components/fx/helpers').makeEventData;
-var dragHelpers = require('../../components/dragelement/helpers');
+var dashStyle = require('../drawing').dashStyle;
+var Color = require('../color');
+var Fx = require('../fx');
+var makeEventData = require('../fx/helpers').makeEventData;
+var dragHelpers = require('../dragelement/helpers');
 var freeMode = dragHelpers.freeMode;
 var rectMode = dragHelpers.rectMode;
 var drawMode = dragHelpers.drawMode;
 var openMode = dragHelpers.openMode;
 var selectMode = dragHelpers.selectMode;
 
-var displayOutlines = require('../../components/shapes/draw_newshape/display_outlines');
-var handleEllipse = require('../../components/shapes/draw_newshape/helpers').handleEllipse;
-var newShapes = require('../../components/shapes/draw_newshape/newshapes');
+var displayOutlines = require('../shapes/draw_newshape/display_outlines');
+var handleEllipse = require('../shapes/draw_newshape/helpers').handleEllipse;
+var newShapes = require('../shapes/draw_newshape/newshapes');
 
 var Lib = require('../../lib');
 var polygon = require('../../lib/polygon');
 var throttle = require('../../lib/throttle');
-var getFromId = require('./axis_ids').getFromId;
+var getFromId = require('../../plots/cartesian/axis_ids').getFromId;
 var clearGlCanvases = require('../../lib/clear_gl_canvases');
 
 var redrawReglTraces = require('../../plot_api/subroutines').redrawReglTraces;

src/plots/cartesian/helpers.js renamed to src/components/selections/helpers.js

@@ -7,7 +7,7 @@ var Axes = require('../../plots/cartesian/axes');
 var readPaths = require('./draw_newshape/helpers').readPaths;
 var displayOutlines = require('./draw_newshape/display_outlines');
 
-var clearOutlineControllers = require('../../plots/cartesian/handle_outline').clearOutlineControllers;
+var clearOutlineControllers = require('../selections/handle_outline').clearOutlineControllers;
 
 var Color = require('../color');
 var Drawing = require('../drawing');

src/plots/cartesian/select.js renamed to src/components/selections/select.js

@@ -12,7 +12,7 @@ var i090 = constants.i090;
 var i180 = constants.i180;
 var i270 = constants.i270;
 
-var handleOutline = require('../../../plots/cartesian/handle_outline');
+var handleOutline = require('../../selections/handle_outline');
 var clearOutlineControllers = handleOutline.clearOutlineControllers;
 
 var helpers = require('./helpers');

src/components/shapes/draw.js

@@ -6,7 +6,7 @@ var constants = require('./constants');
 var CIRCLE_SIDES = constants.CIRCLE_SIDES;
 var SQRT2 = constants.SQRT2;
 
-var cartesianHelpers = require('../../../plots/cartesian/helpers');
+var cartesianHelpers = require('../../selections/helpers');
 var p2r = cartesianHelpers.p2r;
 var r2p = cartesianHelpers.r2p;
 

src/components/shapes/draw_newshape/display_outlines.js

@@ -12,11 +12,11 @@ var i270 = constants.i270;
 var cos45 = constants.cos45;
 var sin45 = constants.sin45;
 
-var cartesianHelpers = require('../../../plots/cartesian/helpers');
+var cartesianHelpers = require('../../selections/helpers');
 var p2r = cartesianHelpers.p2r;
 var r2p = cartesianHelpers.r2p;
 
-var handleOutline = require('../../../plots/cartesian/handle_outline');
+var handleOutline = require('../../selections/handle_outline');
 var clearSelect = handleOutline.clearSelect;
 
 var helpers = require('./helpers');

src/components/shapes/draw_newshape/helpers.js

@@ -19,7 +19,7 @@ var Drawing = require('../components/drawing');
 var Color = require('../components/color');
 var initInteractions = require('../plots/cartesian/graph_interact').initInteractions;
 var xmlnsNamespaces = require('../constants/xmlns_namespaces');
-var clearSelect = require('../plots/cartesian/select').clearSelect;
+var clearSelect = require('../components/selections/select').clearSelect;
 
 var dfltConfig = require('./plot_config').dfltConfig;
 var manageArrays = require('./manage_arrays');

src/components/shapes/draw_newshape/newshapes.js

@@ -29,27 +29,15 @@ module.exports = {
     // pixels to move mouse before you stop clamping to starting point
     MINDRAG: 8,
 
-    // smallest dimension allowed for a select box
-    MINSELECT: 12,
-
     // smallest dimension allowed for a zoombox
     MINZOOM: 20,
 
     // width of axis drag regions
     DRAGGERSIZE: 20,
 
-    // max pixels off straight before a lasso select line counts as bent
-    BENDPX: 1.5,
-
     // delay before a redraw (relayout) after smooth panning and zooming
     REDRAWDELAY: 50,
 
-    // throttling limit (ms) for selectPoints calls
-    SELECTDELAY: 100,
-
-    // cache ID suffix for throttle
-    SELECTID: '-select',
-
     // last resort axis ranges for x and y axes if we have no data
     DFLTRANGEX: [-1, 6],
     DFLTRANGEY: [-1, 4],

src/plot_api/plot_api.js

@@ -26,9 +26,9 @@ var redrawReglTraces = require('../../plot_api/subroutines').redrawReglTraces;
 var Plots = require('../plots');
 
 var getFromId = require('./axis_ids').getFromId;
-var prepSelect = require('./select').prepSelect;
-var clearSelect = require('./select').clearSelect;
-var selectOnClick = require('./select').selectOnClick;
+var prepSelect = require('../../components/selections/select').prepSelect;
+var clearSelect = require('../../components/selections/select').clearSelect;
+var selectOnClick = require('../../components/selections/select').selectOnClick;
 var scaleZoom = require('./scale_zoom');
 
 var constants = require('./constants');

src/plots/cartesian/constants.js

@@ -18,9 +18,9 @@ var Plots = require('../plots');
 var Axes = require('../cartesian/axes');
 var getAutoRange = require('../cartesian/autorange').getAutoRange;
 var dragElement = require('../../components/dragelement');
-var prepSelect = require('../cartesian/select').prepSelect;
-var clearSelect = require('../cartesian/select').clearSelect;
-var selectOnClick = require('../cartesian/select').selectOnClick;
+var prepSelect = require('../../components/selections/select').prepSelect;
+var clearSelect = require('../../components/selections/select').clearSelect;
+var selectOnClick = require('../../components/selections/select').selectOnClick;
 
 var createGeoZoom = require('./zoom');
 var constants = require('./constants');

src/plots/cartesian/dragbox.js

@@ -14,10 +14,10 @@ var rectMode = dragHelpers.rectMode;
 var drawMode = dragHelpers.drawMode;
 var selectMode = dragHelpers.selectMode;
 
-var prepSelect = require('../cartesian/select').prepSelect;
-var clearSelect = require('../cartesian/select').clearSelect;
-var clearSelectionsCache = require('../cartesian/select').clearSelectionsCache;
-var selectOnClick = require('../cartesian/select').selectOnClick;
+var prepSelect = require('../../components/selections/select').prepSelect;
+var clearSelect = require('../../components/selections/select').clearSelect;
+var clearSelectionsCache = require('../../components/selections/select').clearSelectionsCache;
+var selectOnClick = require('../../components/selections/select').selectOnClick;
 
 var constants = require('./constants');
 var createMapboxLayer = require('./layers');

src/plots/geo/geo.js

@@ -13,7 +13,7 @@ var Color = require('../components/color');
 var BADNUM = require('../constants/numerical').BADNUM;
 
 var axisIDs = require('./cartesian/axis_ids');
-var clearSelect = require('./cartesian/handle_outline').clearSelect;
+var clearSelect = require('../components/selections/handle_outline').clearSelect;
 
 var animationAttrs = require('./animation_attributes');
 var frameAttrs = require('./frame_attributes');

src/plots/mapbox/mapbox.js

@@ -18,9 +18,9 @@ var dragBox = require('../cartesian/dragbox');
 var dragElement = require('../../components/dragelement');
 var Fx = require('../../components/fx');
 var Titles = require('../../components/titles');
-var prepSelect = require('../cartesian/select').prepSelect;
-var selectOnClick = require('../cartesian/select').selectOnClick;
-var clearSelect = require('../cartesian/select').clearSelect;
+var prepSelect = require('../../components/selections/select').prepSelect;
+var selectOnClick = require('../../components/selections/select').selectOnClick;
+var clearSelect = require('../../components/selections/select').clearSelect;
 var setCursor = require('../../lib/setcursor');
 var clearGlCanvases = require('../../lib/clear_gl_canvases');
 var redrawReglTraces = require('../../plot_api/subroutines').redrawReglTraces;

src/plots/plots.js

@@ -19,10 +19,10 @@ var dragHelpers = require('../../components/dragelement/helpers');
 var freeMode = dragHelpers.freeMode;
 var rectMode = dragHelpers.rectMode;
 var Titles = require('../../components/titles');
-var prepSelect = require('../cartesian/select').prepSelect;
-var selectOnClick = require('../cartesian/select').selectOnClick;
-var clearSelect = require('../cartesian/select').clearSelect;
-var clearSelectionsCache = require('../cartesian/select').clearSelectionsCache;
+var prepSelect = require('../../components/selections/select').prepSelect;
+var selectOnClick = require('../../components/selections/select').selectOnClick;
+var clearSelect = require('../../components/selections/select').clearSelect;
+var clearSelectionsCache = require('../../components/selections/select').clearSelectionsCache;
 var constants = require('../cartesian/constants');
 
 function Ternary(options, fullLayout) {

src/plots/polar/polar.js

@@ -7,7 +7,7 @@ var fxAttrs = require('../../components/fx/layout_attributes');
 
 var setCursor = require('../../lib/setcursor');
 var dragElement = require('../../components/dragelement');
-var prepSelect = require('../../plots/cartesian/select').prepSelect;
+var prepSelect = require('../../components/selections/select').prepSelect;
 var Lib = require('../../lib');
 var Registry = require('../../registry');