Revert updatemenus initialization and fix sliders initialization

Author: rreusser

src/components/sliders/attributes.js

@@ -68,7 +68,7 @@ module.exports = {
     active: {
         valType: 'number',
         role: 'info',
-        min: -10,
+        min: 0,
         dflt: 0,
         description: [
             'Determines which button (by index starting from 0) is',

src/components/sliders/draw.js

@@ -237,7 +237,9 @@ function drawSlider(gd, sliderGroup, sliderOpts) {
     // Position the rectangle:
     Lib.setTranslate(sliderGroup, sliderOpts.lx + sliderOpts.pad.l, sliderOpts.ly + sliderOpts.pad.t);
 
-    setActive(gd, sliderGroup, sliderOpts, sliderOpts.active, false, false);
+    sliderGroup.call(setGripPosition, sliderOpts, sliderOpts.active / (sliderOpts.steps.length - 1), false);
+    sliderGroup.call(drawCurrentValue, sliderOpts);
+
 }
 
 function drawCurrentValue(sliderGroup, sliderOpts, valueOverride) {

src/components/updatemenus/defaults.js

@@ -33,8 +33,6 @@ module.exports = function updateMenusDefaults(layoutIn, layoutOut) {
         // used to determine object constancy
         menuOut._index = i;
 
-        menuOut._input.active = menuOut.active;
-
         contOut.push(menuOut);
     }
 };

test/jasmine/tests/command_test.js

@@ -555,7 +555,7 @@ describe('attaching component bindings', function() {
             expect(typeof gd._internalEv._events.plotly_animatingframe).toBe('function');
 
             // Confirm the first position is selected:
-            expect(gd.layout.sliders[0].active).toBe(0);
+            expect(gd.layout.sliders[0].active).toBeUndefined();
 
             // Modify the plot
             return Plotly.restyle(gd, {'marker.color': 'blue'});
@@ -608,7 +608,7 @@ describe('attaching component bindings', function() {
             expect(typeof gd._internalEv._events.plotly_animatingframe).toBe('function');
 
             // Confirm the first position is selected:
-            expect(gd.layout.updatemenus[0].active).toBe(0);
+            expect(gd.layout.updatemenus[0].active).toBeUndefined();
 
             // Modify the plot
             return Plotly.restyle(gd, {'marker.color': 'blue'});

test/jasmine/tests/sliders_test.js

@@ -182,7 +182,34 @@ describe('sliders defaults', function() {
     });
 });
 
-describe('update sliders interactions', function() {
+describe('sliders initialization', function() {
+    'use strict';
+    var gd;
+
+    beforeEach(function(done) {
+        gd = createGraphDiv();
+
+        Plotly.plot(gd, [{x: [1, 2, 3]}], {
+            sliders: [{
+                steps: [
+                    {method: 'restyle', args: [], label: 'first'},
+                    {method: 'restyle', args: [], label: 'second'},
+                ]
+            }]
+        }).then(done);
+    });
+
+    afterEach(function() {
+        Plotly.purge(gd);
+        destroyGraphDiv();
+    });
+
+    it('does not set active on initial plot', function() {
+        expect(gd.layout.sliders[0].active).toBeUndefined();
+    });
+});
+
+describe('sliders interactions', function() {
     'use strict';
 
     var mock = require('@mocks/sliders.json');

test/jasmine/tests/updatemenus_test.js

@@ -225,6 +225,33 @@ describe('update menus buttons', function() {
     }
 });
 
+describe('update menus initialization', function() {
+    'use strict';
+    var gd;
+
+    beforeEach(function(done) {
+        gd = createGraphDiv();
+
+        Plotly.plot(gd, [{x: [1, 2, 3]}], {
+            updatemenus: [{
+                buttons: [
+                    {method: 'restyle', args: [], label: 'first'},
+                    {method: 'restyle', args: [], label: 'second'},
+                ]
+            }]
+        }).then(done);
+    });
+
+    afterEach(function() {
+        Plotly.purge(gd);
+        destroyGraphDiv();
+    });
+
+    it('does not set active on initial plot', function() {
+        expect(gd.layout.updatemenus[0].active).toBeUndefined();
+    });
+});
+
 describe('update menus interactions', function() {
     'use strict';