Skip to content

Commit ded2f56

Browse files
committed
add makeComputeError to errorbars module, call it w/ Registry
1 parent 82290a2 commit ded2f56

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

src/components/errorbars/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ var Lib = require('../../lib');
1212
var overrideAll = require('../../plot_api/edit_types').overrideAll;
1313

1414
var attributes = require('./attributes');
15-
var calc = require('./calc');
1615

1716
var xyAttrs = {
1817
error_x: Lib.extendFlat({}, attributes),
@@ -48,7 +47,8 @@ module.exports = {
4847

4948
supplyDefaults: require('./defaults'),
5049

51-
calc: calc,
50+
calc: require('./calc'),
51+
makeComputeError: require('./compute_error'),
5252

5353
plot: require('./plot'),
5454
style: require('./style'),

src/traces/scatter3d/calc_errors.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@
66
* LICENSE file in the root directory of this source tree.
77
*/
88

9-
109
'use strict';
1110

12-
var makeComputeError = require('../../components/errorbars/compute_error');
11+
var Registry = require('../../registry');
1312

1413
function calculateAxisErrors(data, params, scaleFactor) {
1514
if(!params || !params.visible) return null;
1615

17-
var computeError = makeComputeError(params);
16+
var computeError = Registry.getComponentMethod('errorbars', 'makeComputeError')(params);
1817
var result = new Array(data.length);
1918

2019
for(var i = 0; i < data.length; i++) {

src/traces/scattergl/convert.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ var AxisIDs = require('../../plots/cartesian/axis_ids');
2121
var formatColor = require('../../lib/gl_format_color').formatColor;
2222
var subTypes = require('../scatter/subtypes');
2323
var makeBubbleSizeFn = require('../scatter/make_bubble_size_func');
24-
var makeComputeError = require('../../components/errorbars/compute_error');
2524

2625
var constants = require('./constants');
2726
var DESELECTDIM = require('../../constants/interactions').DESELECTDIM;
@@ -364,6 +363,7 @@ function convertLinePositions(gd, trace, positions) {
364363
}
365364

366365
function convertErrorBarPositions(gd, trace, positions, x, y) {
366+
var makeComputeError = Registry.getComponentMethod('errorbars', 'makeComputeError');
367367
var xa = AxisIDs.getFromId(gd, trace.xaxis);
368368
var ya = AxisIDs.getFromId(gd, trace.yaxis);
369369
var count = positions.length / 2;

0 commit comments

Comments
 (0)