Skip to content

Commit dd3cfaf

Browse files
committed
rename hovergaps to hoverongaps
1 parent 0a4feb3 commit dd3cfaf

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

src/traces/contour/attributes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module.exports = extendFlat({
3838
ytype: heatmapAttrs.ytype,
3939
zhoverformat: heatmapAttrs.zhoverformat,
4040
hovertemplate: heatmapAttrs.hovertemplate,
41-
hovergaps: heatmapAttrs.hovergaps,
41+
hoverongaps: heatmapAttrs.hoverongaps,
4242
connectgaps: extendFlat({}, heatmapAttrs.connectgaps, {
4343
description: [
4444
'Determines whether or not gaps',

src/traces/contour/defaults.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
3535
coerce('text');
3636
coerce('hovertext');
3737
coerce('hovertemplate');
38-
coerce('hovergaps');
38+
coerce('hoverongaps');
3939

4040
var isConstraint = (coerce('contours.type') === 'constraint');
4141
coerce('connectgaps', Lib.isArray1D(traceOut.z));

src/traces/heatmap/attributes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ module.exports = extendFlat({
7979
'Picks a smoothing algorithm use to smooth `z` data.'
8080
].join(' ')
8181
},
82-
hovergaps: {
82+
hoverongaps: {
8383
valType: 'boolean',
8484
dflt: true,
8585
role: 'style',

src/traces/heatmap/defaults.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
3434

3535
handleStyleDefaults(traceIn, traceOut, coerce, layout);
3636

37-
coerce('hovergaps');
37+
coerce('hoverongaps');
3838
coerce('connectgaps', Lib.isArray1D(traceOut.z) && (traceOut.zsmooth !== false));
3939

4040
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'z'});

src/traces/heatmap/hover.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLay
112112
var zVal = z[ny][nx];
113113
if(zmask && !zmask[ny][nx]) zVal = undefined;
114114

115-
if(zVal !== undefined || trace.hovergaps) {
115+
if(zVal !== undefined || trace.hoverongaps) {
116116
// dummy axis for formatting the z value
117117
var cOpts = extractOpts(trace);
118118
var dummyAx = {

test/jasmine/tests/contour_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -637,13 +637,13 @@ describe('contour hover', function() {
637637
y: [100, 100, 101, 101],
638638
z: [null, 1, 2, 3],
639639
connectgaps: false,
640-
hovergaps: false
640+
hoverongaps: false
641641
}]
642642
}).then(done);
643643
});
644644
afterAll(destroyGraphDiv);
645645

646-
it('should not create zLabels when hovering on missing data and hovergaps is disabled', function() {
646+
it('should not create zLabels when hovering on missing data and hoverongaps is disabled', function() {
647647
var pt = _hover(gd, 10, 100)[0];
648648

649649
expect(pt.index).toEqual([0, 0], 'have correct index');

test/jasmine/tests/heatmap_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -988,13 +988,13 @@ describe('heatmap hover', function() {
988988
y: [100, 100, 101, 101],
989989
z: [null, 1, 2, 3],
990990
connectgaps: false,
991-
hovergaps: false
991+
hoverongaps: false
992992
}]
993993
}).then(done);
994994
});
995995
afterAll(destroyGraphDiv);
996996

997-
it('should not create zLabels when hovering on missing data and hovergaps is disabled', function() {
997+
it('should not create zLabels when hovering on missing data and hoverongaps is disabled', function() {
998998
var pt = _hover(gd, 10, 100)[0];
999999

10001000
expect(pt.index).toEqual([0, 0], 'have correct index');

0 commit comments

Comments
 (0)