Skip to content

Commit dae3ccd

Browse files
committed
🔪 hoveron declaration in scattergl and scatterpolargl
... until we actually implement it in #2887
1 parent 449dc43 commit dae3ccd

File tree

4 files changed

+2
-19
lines changed

4 files changed

+2
-19
lines changed

src/traces/scattergl/attributes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ var attrs = module.exports = overrideAll({
7878
fill: scatterAttrs.fill,
7979
fillcolor: scatterAttrs.fillcolor,
8080

81-
hoveron: scatterAttrs.hoveron,
81+
// no hoveron
8282

8383
selected: {
8484
marker: scatterAttrs.selected.marker,

src/traces/scattergl/defaults.js

-9
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,9 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
4444
handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce);
4545
}
4646

47-
var dfltHoverOn = [];
48-
4947
if(subTypes.hasMarkers(traceOut)) {
5048
handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce);
5149
coerce('marker.line.width', isOpen || isBubble ? 1 : 0);
52-
dfltHoverOn.push('points');
5350
}
5451

5552
if(subTypes.hasText(traceOut)) {
@@ -61,12 +58,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
6158
handleFillColorDefaults(traceIn, traceOut, defaultColor, coerce);
6259
}
6360

64-
if(traceOut.fill === 'tonext' || traceOut.fill === 'toself') {
65-
dfltHoverOn.push('fills');
66-
}
67-
68-
coerce('hoveron', dfltHoverOn.join('+') || 'points');
69-
7061
var errorBarsSupplyDefaults = Registry.getComponentMethod('errorbars', 'supplyDefaults');
7162
errorBarsSupplyDefaults(traceIn, traceOut, defaultColor, {axis: 'y'});
7263
errorBarsSupplyDefaults(traceIn, traceOut, defaultColor, {axis: 'x', inherit: 'y'});

src/traces/scatterpolargl/attributes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = {
3434
fillcolor: scatterGlAttrs.fillcolor,
3535

3636
hoverinfo: scatterPolarAttrs.hoverinfo,
37-
hoveron: scatterPolarAttrs.hoveron,
37+
// no hoveron
3838

3939
selected: scatterPolarAttrs.selected,
4040
unselected: scatterPolarAttrs.unselected

src/traces/scatterpolargl/defaults.js

-8
Original file line numberDiff line numberDiff line change
@@ -39,22 +39,14 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
3939
coerce('connectgaps');
4040
}
4141

42-
var dfltHoverOn = [];
43-
4442
if(subTypes.hasMarkers(traceOut)) {
4543
handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce);
46-
dfltHoverOn.push('points');
4744
}
4845

4946
coerce('fill');
5047
if(traceOut.fill !== 'none') {
5148
handleFillColorDefaults(traceIn, traceOut, defaultColor, coerce);
5249
}
5350

54-
if(traceOut.fill === 'tonext' || traceOut.fill === 'toself') {
55-
dfltHoverOn.push('fills');
56-
}
57-
coerce('hoveron', dfltHoverOn.join('+') || 'points');
58-
5951
Lib.coerceSelectionMarkerOpacity(traceOut, coerce);
6052
};

0 commit comments

Comments
 (0)