Skip to content

Commit da81a0e

Browse files
committed
no need to stash splom grid data on fullLayout
1 parent 2e6b610 commit da81a0e

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/traces/splom/base_plot.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ function drawGrid(gd) {
9595
splomGrid = fullLayout._splomGrid = createLine(regl);
9696
}
9797

98-
splomGrid._data = makeGridData(gd);
99-
splomGrid.update(splomGrid._data);
98+
splomGrid.update(makeGridData(gd));
10099
splomGrid.draw();
101100
}
102101

test/jasmine/tests/splom_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,8 @@ describe('@gl Test splom interactions:', function() {
371371
var cnt = 1;
372372

373373
function _assert(dims) {
374-
var gridData = gd._fullLayout._splomGrid._data;
375-
var gridLengths = gridData.map(function(d) { return d.data.length; });
374+
var gridData = gd._fullLayout._splomGrid.lines;
375+
var gridLengths = gridData.map(function(d) { return d.positions.length; });
376376
var msg = ' - call #' + cnt;
377377

378378
expect(Object.keys(gridData).length)

0 commit comments

Comments
 (0)