improve scatterpolar hover

Author: etpinard

src/plots/polar/layout_defaults.js

@@ -221,6 +221,9 @@ function setConvertAngular(ax) {
     // angularaxis 'position' and/or 'direction'
     ax.unTransformRad = unTransformRad;
 
+    // this version is used on hover
+    ax._c2rad = _c2rad;
+
     ax.c2rad = function(v, unit) { return transformRad(_c2rad(v, unit)); };
     ax.rad2c = function(v, unit) { return _rad2c(unTransformRad(v), unit); };
 

src/plots/polar/polar.js

@@ -435,6 +435,17 @@ proto.updateAngularAxis = function(fullLayout, polarLayout) {
     .call(Color.stroke, angularLayout.linecolor);
 };
 
+proto.isPtWithinSector = function() {
+    var sector = this.sector;
+
+    if(isFullCircle(sector)) return true;
+
+    // check out https://stackoverflow.com/a/13675772/4068492
+    // for possible solution
+    // var deg = wrap360(rad2deg(d.rad));
+    return true;
+};
+
 function setScale(ax, axLayout, fullLayout) {
     Axes.setConvert(ax, fullLayout);
 

src/traces/scatterpolar/hover.js

@@ -9,12 +9,58 @@
 'use strict';
 
 var scatterHover = require('../scatter/hover');
+var Axes = require('../../plots/cartesian/axes');
+var Lib = require('../../lib');
 
 module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
     var scatterPointData = scatterHover(pointData, xval, yval, hovermode);
     if(!scatterPointData || scatterPointData[0].index === false) return;
 
     var newPointData = scatterPointData[0];
 
+    // hovering on fill case
+    // TODO do we need to constrain the scatter point data further (like for
+    // ternary subplots) or not?
+    if(newPointData.index === undefined) {
+        return scatterPointData;
+    }
+
+    var subplot = pointData.subplot;
+    var cdi = newPointData.cd[newPointData.index];
+
+    if(!subplot.isPtWithinSector(cdi)) return;
+
+    newPointData.xLabelVal = undefined;
+    newPointData.yLabelVal = undefined;
+
+    var trace = newPointData.trace;
+    var radialAxis = subplot.radialAxis;
+    var angularAxis = subplot.angularAxis;
+    var hoverinfo = cdi.hi || trace.hoverinfo;
+    var parts = hoverinfo.split('+');
+    var text = [];
+    var rad = angularAxis._c2rad(cdi.theta, trace.thetaunit);
+
+    radialAxis._hovertitle = 'r';
+    angularAxis._hovertitle = 'θ';
+
+    // show theta value in unit of angular axis
+    var theta;
+    if(angularAxis.type === 'linear' && trace.thetaunit !== angularAxis.thetaunit) {
+        theta = angularAxis.thetaunit === 'degrees' ? Lib.rad2deg(rad) : rad;
+    } else {
+        theta = cdi.theta;
+    }
+
+    function textPart(ax, val) {
+        text.push(ax._hovertitle + ': ' + Axes.tickText(ax, val, 'hover').text);
+    }
+
+    if(parts.indexOf('all') !== -1) parts = ['r', 'theta'];
+    if(parts.indexOf('r') !== -1) textPart(radialAxis, cdi.r);
+    if(parts.indexOf('theta') !== -1) textPart(angularAxis, theta);
+
+    newPointData.extraText = text.join('<br>');
+
     return scatterPointData;
 };

src/traces/scatterpolar/plot.js

@@ -8,6 +8,7 @@
 
 'use strict';
 
+var Lib = require('../../lib');
 var scatterPlot = require('../scatter/plot');
 
 module.exports = function plot(subplot, moduleCalcData) {
@@ -23,4 +24,35 @@ module.exports = function plot(subplot, moduleCalcData) {
     };
 
     scatterPlot(subplot.graphDiv, plotinfo, moduleCalcData);
+
+    function pt2deg(p) {
+        return Lib.rad2deg(Math.atan2(radius - p[1], p[0] - radius));
+    }
+
+    // TODO
+    // fix polygon testers for segments that wrap around themselves
+    // about the origin.
+    for(var i = 0; i < moduleCalcData.length; i++) {
+        var trace = moduleCalcData[i][0].trace;
+
+        if(Array.isArray(trace._polygons)) {
+            for(var j = 0; j < trace._polygons.length; j++) {
+                var pts = trace._polygons[j].pts.slice();
+                pts.pop();
+
+                var a0 = pt2deg(pts[0]);
+                for(var k = 1; k < pts.length; k++) {
+                    var a1 = pt2deg(pts[k]);
+                    var arc = Math.abs(a1 - a0);
+                    var arcWrapped = Math.abs(Lib.wrap360(a1) - Lib.wrap360(a0));
+
+                    if(arc !== arcWrapped) {
+                        // pts.push(radius, radius);
+                    }
+
+                    a0 = a1;
+                }
+            }
+        }
+    }
 };

test/jasmine/tests/scatterpolar_test.js

@@ -34,3 +34,11 @@ describe('Test scatterpolar trace defaults:', function() {
 describe('Test scatterpolar calc:', function() {
 
 });
+
+describe('Test scatterpolar hover:', function() {
+    // gd;
+
+    it('', function() {
+
+    });
+});