Skip to content

Commit da3ef58

Browse files
committed
fixing pixel padding issue with filter
1 parent be619b9 commit da3ef58

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/traces/parcoords/lines.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010

1111
var createREGL = require('regl');
1212
var glslify = require('glslify');
13+
var verticalPadding = require('./constants').verticalPadding;
1314
var vertexShaderSource = glslify('./shaders/vertex.glsl');
1415
var pickVertexShaderSource = glslify('./shaders/pick_vertex.glsl');
1516
var fragmentShaderSource = glslify('./shaders/fragment.glsl');
1617

1718
var depthLimitEpsilon = 1e-6; // don't change; otherwise near/far plane lines are lost
18-
var filterEpsilon = 1e-3; // don't change; otherwise filter may lose lines on domain boundaries
1919

2020
var gpuDimensionCount = 64;
2121
var sectionVertexCount = 2;
@@ -297,6 +297,7 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, initialDim
297297
function makeItem(i, ii, x, y, panelSizeX, canvasPanelSizeY, crossfilterDimensionIndex, scatter, I, leftmost, rightmost) {
298298
var loHi, abcd, d, index;
299299
var leftRight = [i, ii];
300+
var filterEpsilon = verticalPadding / canvasPanelSizeY;
300301

301302
var dims = [0, 1].map(function() {return [0, 1, 2, 3].map(function() {return new Float32Array(16);});});
302303
var lims = [0, 1].map(function() {return [0, 1, 2, 3].map(function() {return new Float32Array(16);});});
Loading

0 commit comments

Comments
 (0)