supplyDataDefaults instead of supplyDefaults for transitions

Author: rreusser

src/plot_api/plot_api.js

@@ -2590,7 +2590,7 @@ Plotly.transition = function(gd, data, layout, traceIndices, transitionConfig) {
             Lib.extendDeepNoArrays(gd.data[traceIndices[i]], update);
         }
 
-        Plots.supplyDefaults(gd);
+        Plots.supplyDataDefaults(gd.data, gd._fullData, gd._fullLayout);
 
         // TODO: Add logic that computes transitionedTraces to avoid unnecessary work while
         // still handling things like box plots that are interrelated.

src/plots/cartesian/dragbox.js

@@ -613,7 +613,6 @@ module.exports = function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
                 editX = ew && xa.indexOf(xa2) !== -1 && !xa2.fixedrange,
                 editY = ns && ya.indexOf(ya2) !== -1 && !ya2.fixedrange;
 
-
             var xScaleFactor = editX ? xa2._length / viewBox[2] : 1,
                 yScaleFactor = editY ? ya2._length / viewBox[3] : 1;
 

src/plots/plots.js

@@ -508,20 +508,6 @@ plots.supplyDefaults = function(gd) {
     // relink functions and _ attributes to promote consistency between plots
     relinkPrivateKeys(newFullLayout, oldFullLayout);
 
-    // XXX: This is a hack that should be refactored by more generally removing the
-    // need for relinkPrivateKeys
-    var subplots = plots.getSubplotIds(newFullLayout, 'cartesian');
-    for(i = 0; i < subplots.length; i++) {
-        var subplot = newFullLayout._plots[subplots[i]];
-        if(subplot.xaxis) {
-            subplot.xaxis = newFullLayout[subplot.xaxis._name];
-        }
-        if(subplot.yaxis) {
-            subplot.yaxis = newFullLayout[subplot.yaxis._name];
-        }
-    }
-
-
     plots.doAutoMargin(gd);
 
     // can't quite figure out how to get rid of this... each axis needs
@@ -678,6 +664,9 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout) {
         basePlotModules = layout._basePlotModules = [],
         cnt = 0;
 
+    // Make this idempotent by emptying the existing array:
+    dataOut.length = 0;
+
     function pushModule(fullTrace) {
         dataOut.push(fullTrace);