Skip to content

Commit d96e5e1

Browse files
authored
Merge pull request #731 from monfera/raf-lighten
Bypassing most of the heavy lifting in the rAF for when there's no interaction
2 parents f6d2ddc + d58a37f commit d96e5e1

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/plots/gl2d/scene2d.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -483,11 +483,15 @@ proto.draw = function() {
483483

484484
if(nextSelection && (
485485
!this.lastPickResult ||
486-
this.lastPickResult.trace !== nextSelection.trace ||
486+
this.lastPickResult.traceUid !== nextSelection.trace.uid ||
487487
this.lastPickResult.dataCoord[0] !== nextSelection.dataCoord[0] ||
488488
this.lastPickResult.dataCoord[1] !== nextSelection.dataCoord[1])
489489
) {
490-
var selection = this.lastPickResult = nextSelection;
490+
var selection = nextSelection;
491+
this.lastPickResult = {
492+
traceUid: nextSelection.trace ? nextSelection.trace.uid : null,
493+
dataCoord: nextSelection.dataCoord.slice()
494+
};
491495
this.spikes.update({ center: result.dataCoord });
492496

493497
selection.screenCoord = [
@@ -523,8 +527,6 @@ proto.draw = function() {
523527
}, {
524528
container: this.svgContainer
525529
});
526-
527-
this.lastPickResult = { dataCoord: result.dataCoord };
528530
}
529531
}
530532
else if(!result && this.lastPickResult) {

0 commit comments

Comments
 (0)