Skip to content

Commit d617a1b

Browse files
authored
Merge pull request #3859 from plotly/flaky-gl-ci-fixes
Reorganise gl tests for less flakiness
2 parents e26f8f4 + a27c519 commit d617a1b

16 files changed

+1782
-1844
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
docker:
5454
# need '-browsers' version to test in real (xvfb-wrapped) browsers
5555
- image: circleci/node:10.9.0-browsers
56-
parallelism: 2
56+
parallelism: 3
5757
working_directory: ~/plotly.js
5858
steps:
5959
- attach_workspace:

test/jasmine/tests/gl2d_scatterplot_contour_test.js renamed to test/jasmine/tests/contourgl_test.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict';
2-
31
var Plotly = require('@lib/index');
42
var Lib = require('@src/lib');
53
var d3 = require('d3');
@@ -197,25 +195,25 @@ describe('contourgl plots', function() {
197195
makePlot(gd, mockCopy, done);
198196
});
199197

200-
it('render without raising an error (coloring: "lines")', function(done) {
198+
it('@gl render without raising an error (coloring: "lines")', function(done) {
201199
var mock = Lib.extendDeep({}, plotDataElliptical(0));
202200
mock.data[0].contours.coloring = 'lines'; // 'fill' is the default
203201
makePlot(gd, mock, done);
204202
});
205203

206-
it('render smooth, regular ellipses without raising an error (coloring: "fill")', function(done) {
204+
it('@gl render smooth, regular ellipses without raising an error (coloring: "fill")', function(done) {
207205
var mock = plotDataElliptical(0);
208206
makePlot(gd, mock, done);
209207
});
210208

211-
it('render ellipses with added noise without raising an error (coloring: "fill")', function(done) {
209+
it('@gl render ellipses with added noise without raising an error (coloring: "fill")', function(done) {
212210
var mock = plotDataElliptical(0.5);
213211
mock.data[0].contours.coloring = 'fill'; // 'fill' is the default
214212
mock.data[0].line = {smoothing: 0};
215213
makePlot(gd, mock, done);
216214
});
217215

218-
it('should update properly', function(done) {
216+
it('@gl should update properly', function(done) {
219217
var mock = plotDataElliptical(0);
220218
var scene2d;
221219

test/jasmine/tests/gl2d_date_axis_render_test.js

-105
This file was deleted.

0 commit comments

Comments
 (0)