Skip to content

Commit d46cae7

Browse files
committed
merge custom shared assertions into single assets/ module
1 parent 4b5c4bb commit d46cae7

File tree

5 files changed

+27
-25
lines changed

5 files changed

+27
-25
lines changed

test/jasmine/assets/assert_dims.js

-18
This file was deleted.

test/jasmine/assets/assert_style.js renamed to test/jasmine/assets/custom_assertions.js

+16-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,22 @@
22

33
var d3 = require('d3');
44

5-
module.exports = function assertStyle(dims, color, opacity) {
5+
exports.assertDims = function(dims) {
6+
var traces = d3.selectAll('.trace');
7+
8+
expect(traces.size())
9+
.toEqual(dims.length, 'to have correct number of traces');
10+
11+
traces.each(function(_, i) {
12+
var trace = d3.select(this);
13+
var points = trace.selectAll('.point');
14+
15+
expect(points.size())
16+
.toEqual(dims[i], 'to have correct number of pts in trace ' + i);
17+
});
18+
};
19+
20+
exports.assertStyle = function(dims, color, opacity) {
621
var N = dims.reduce(function(a, b) {
722
return a + b;
823
});

test/jasmine/tests/transform_filter_test.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@ var Lib = require('@src/lib');
66

77
var createGraphDiv = require('../assets/create_graph_div');
88
var destroyGraphDiv = require('../assets/destroy_graph_div');
9-
var assertDims = require('../assets/assert_dims');
10-
var assertStyle = require('../assets/assert_style');
119
var customMatchers = require('../assets/custom_matchers');
10+
var customAssertions = require('../assets/custom_assertions');
11+
12+
var assertDims = customAssertions.assertDims;
13+
var assertStyle = customAssertions.assertStyle;
1214

1315
describe('filter transforms defaults:', function() {
1416

test/jasmine/tests/transform_groupby_test.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ var Lib = require('@src/lib');
33

44
var createGraphDiv = require('../assets/create_graph_div');
55
var destroyGraphDiv = require('../assets/destroy_graph_div');
6-
var assertDims = require('../assets/assert_dims');
7-
var assertStyle = require('../assets/assert_style');
6+
var customAssertions = require('../assets/custom_assertions');
7+
8+
var assertDims = customAssertions.assertDims;
9+
var assertStyle = customAssertions.assertStyle;
810

911
describe('groupby', function() {
1012

test/jasmine/tests/transform_multi_test.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ var Lib = require('@src/lib');
66

77
var createGraphDiv = require('../assets/create_graph_div');
88
var destroyGraphDiv = require('../assets/destroy_graph_div');
9-
var assertDims = require('../assets/assert_dims');
10-
var assertStyle = require('../assets/assert_style');
9+
var customAssertions = require('../assets/custom_assertions');
1110

11+
var assertDims = customAssertions.assertDims;
12+
var assertStyle = customAssertions.assertStyle;
1213

1314
describe('general transforms:', function() {
1415
'use strict';

0 commit comments

Comments
 (0)