Merge pull request #4306 from plotly/fix4072-cone-showup

Handle data with identical positions in cone plots

Author: archmoj

package-lock.json

@@ -73,7 +73,7 @@
     "delaunay-triangulate": "^1.1.6",
     "es6-promise": "^3.0.2",
     "fast-isnumeric": "^1.1.3",
-    "gl-cone3d": "^1.5.0",
+    "gl-cone3d": "^1.5.1",
     "gl-contour2d": "^1.1.6",
     "gl-error3d": "^1.0.15",
     "gl-heatmap2d": "^1.0.5",

package.json

@@ -177,6 +177,39 @@ describe('Test cone autorange:', function() {
     });
 });
 
+describe('Test cone autorange:', function() {
+    var gd;
+
+    beforeEach(function() {
+        gd = createGraphDiv();
+    });
+
+    afterEach(function() {
+        Plotly.purge(gd);
+        destroyGraphDiv();
+    });
+
+    it('@gl should skip identical positions in calculating cone vectorScale', function(done) {
+        Plotly.plot(gd, {
+            data: [
+                {
+                    type: 'cone',
+                    x: [-1, -1, -3, -4],
+                    y: [1, 1, 3, 4],
+                    z: [1, 1, 3, 4],
+                    u: [-1, 2, -3, -4],
+                    v: [1, -2, 3, 4],
+                    w: [1, -2, 3, 4]
+                }
+            ]
+        }).then(function() {
+            expect(gd._fullLayout.scene._scene.glplot.objects[0].vectorScale).toBeCloseTo(0.2857, 4);
+        })
+        .catch(failTest)
+        .then(done);
+    });
+});
+
 describe('Test cone interactions', function() {
     var gd;