Skip to content

Commit cb0202c

Browse files
committed
lint range slider visibility suite
1 parent 3274284 commit cb0202c

File tree

1 file changed

+39
-26
lines changed

1 file changed

+39
-26
lines changed

test/jasmine/tests/range_slider_test.js

Lines changed: 39 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -294,43 +294,56 @@ describe('the range slider', function() {
294294

295295
it('should not add the slider to the DOM by default', function(done) {
296296
Plotly.plot(gd, [{ x: [1, 2, 3], y: [2, 3, 4] }], {})
297-
.then(function() {
298-
var rangeSlider = getRangeSlider();
299-
expect(rangeSlider).not.toBeDefined();
300-
})
301-
.then(done);
297+
.then(function() {
298+
var rangeSlider = getRangeSlider();
299+
expect(rangeSlider).not.toBeDefined();
300+
})
301+
.then(done);
302302
});
303303

304304
it('should add the slider if rangeslider is set to anything', function(done) {
305305
Plotly.plot(gd, [{ x: [1, 2, 3], y: [2, 3, 4] }], {})
306-
.then(function() { Plotly.relayout(gd, 'xaxis.rangeslider', 'exists'); })
307-
.then(function() {
308-
var rangeSlider = getRangeSlider();
309-
expect(rangeSlider).toBeDefined();
310-
})
311-
.then(done);
306+
.then(function() {
307+
return Plotly.relayout(gd, 'xaxis.rangeslider', 'exists');
308+
})
309+
.then(function() {
310+
var rangeSlider = getRangeSlider();
311+
expect(rangeSlider).toBeDefined();
312+
})
313+
.then(done);
312314
});
313315

314316
it('should add the slider if visible changed to `true`', function(done) {
315317
Plotly.plot(gd, [{ x: [1, 2, 3], y: [2, 3, 4] }], {})
316-
.then(function() { Plotly.relayout(gd, 'xaxis.rangeslider.visible', true); })
317-
.then(function() {
318-
var rangeSlider = getRangeSlider();
319-
expect(rangeSlider).toBeDefined();
320-
expect(countRangeSliderClipPaths()).toEqual(1);
321-
})
322-
.then(done);
318+
.then(function() {
319+
return Plotly.relayout(gd, 'xaxis.rangeslider.visible', true);
320+
})
321+
.then(function() {
322+
var rangeSlider = getRangeSlider();
323+
expect(rangeSlider).toBeDefined();
324+
expect(countRangeSliderClipPaths()).toEqual(1);
325+
})
326+
.then(done);
323327
});
324328

325329
it('should remove the slider if changed to `false` or `undefined`', function(done) {
326-
Plotly.plot(gd, [{ x: [1, 2, 3], y: [2, 3, 4] }], { xaxis: { rangeslider: { visible: true }}})
327-
.then(function() { Plotly.relayout(gd, 'xaxis.rangeslider.visible', false); })
328-
.then(function() {
329-
var rangeSlider = getRangeSlider();
330-
expect(rangeSlider).not.toBeDefined();
331-
expect(countRangeSliderClipPaths()).toEqual(0);
332-
})
333-
.then(done);
330+
Plotly.plot(gd, [{
331+
x: [1, 2, 3],
332+
y: [2, 3, 4]
333+
}], {
334+
xaxis: {
335+
rangeslider: { visible: true }
336+
}
337+
})
338+
.then(function() {
339+
return Plotly.relayout(gd, 'xaxis.rangeslider.visible', false);
340+
})
341+
.then(function() {
342+
var rangeSlider = getRangeSlider();
343+
expect(rangeSlider).not.toBeDefined();
344+
expect(countRangeSliderClipPaths()).toEqual(0);
345+
})
346+
.then(done);
334347
});
335348
});
336349

0 commit comments

Comments
 (0)