Skip to content

Commit c7e5a22

Browse files
authored
Merge pull request #5388 from plotly/switch-to-probe-image-size
Use probe-image-size module to read width and height of images
2 parents d110973 + ff635ae commit c7e5a22

File tree

4 files changed

+70
-15
lines changed

4 files changed

+70
-15
lines changed

package-lock.json

+65-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@
9797
"glslify": "^7.1.1",
9898
"has-hover": "^1.0.1",
9999
"has-passive-events": "^1.0.0",
100-
"image-size": "^0.7.5",
101100
"is-mobile": "^2.2.2",
102101
"mapbox-gl": "1.10.1",
103102
"matrix-camera-controller": "^2.1.3",
@@ -109,6 +108,7 @@
109108
"ndarray-linear-interpolate": "^1.0.0",
110109
"parse-svg-path": "^0.1.2",
111110
"polybooljs": "^1.2.0",
111+
"probe-image-size": "^6.0.0",
112112
"regl": "^1.6.1",
113113
"regl-error2d": "^2.0.11",
114114
"regl-line2d": "^3.1.0",

src/traces/image/helpers.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88

99
'use strict';
1010

11-
var sizeOf = require('image-size');
11+
var probeSync = require('probe-image-size/sync');
1212
var dataUri = require('../../snapshot/helpers').IMAGE_URL_PREFIX;
1313
var Buffer = require('buffer/').Buffer; // note: the trailing slash is important!
1414

1515
exports.getImageSize = function(src) {
1616
var data = src.replace(dataUri, '');
1717
var buff = new Buffer(data, 'base64');
18-
return sizeOf(buff);
18+
return probeSync(buff);
1919
};

test/image/export_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
var fs = require('fs');
2-
var sizeOf = require('image-size');
2+
var probeSync = require('probe-image-size/sync');
33

44
var getMockList = require('./assets/get_mock_list');
55
var getRequestOpts = require('./assets/get_image_request_options');
@@ -121,7 +121,7 @@ function testExport(mockName, format, cb) {
121121
var didExport;
122122

123123
if(format === 'svg') {
124-
var dims = sizeOf(imagePaths.test);
124+
var dims = probeSync(fs.readFileSync(imagePaths.test));
125125
didExport = (dims.width === WIDTH) && (dims.height === HEIGHT);
126126
} else {
127127
var stats = fs.statSync(imagePaths.test);

0 commit comments

Comments
 (0)