Skip to content

Commit c3f0a18

Browse files
authored
Merge pull request #2076 from plotly/table-firefox-baseline
Phase out *-baseline in `table` as IE doesn't follow this part of the SVG standard
2 parents 1c3b6b5 + ea94d21 commit c3f0a18

11 files changed

+3
-4
lines changed

src/traces/parcoords/parcoords.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,6 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
636636
axisExtentTopText.enter()
637637
.append('text')
638638
.classed(c.cn.axisExtentTopText, true)
639-
.attr('alignment-baseline', 'after-edge')
640639
.call(styleExtentTexts);
641640

642641
axisExtentTopText
@@ -659,7 +658,7 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
659658
axisExtentBottomText.enter()
660659
.append('text')
661660
.classed(c.cn.axisExtentBottomText, true)
662-
.attr('alignment-baseline', 'before-edge')
661+
.attr('dy', '0.75em')
663662
.call(styleExtentTexts);
664663

665664
axisExtentBottomText

src/traces/table/plot.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,8 @@ function populateCellText(cellText, tableControlView, allColumnBlock, gd) {
529529

530530
return textToRender;
531531
})
532-
.attr('alignment-baseline', function(d) {
533-
return d.needsConvertToTspans ? null : 'hanging';
532+
.attr('dy', function(d) {
533+
return d.needsConvertToTspans ? 0 : '0.75em';
534534
})
535535
.each(function(d) {
536536

58 Bytes
Loading
-7 Bytes
Loading
12 Bytes
Loading
-3 Bytes
Loading
30 Bytes
Loading
16 Bytes
Loading
Loading
11 Bytes
Loading
19 Bytes
Loading

0 commit comments

Comments
 (0)