Skip to content

Commit c35aac5

Browse files
committed
need to change indicator delta auto default format
1 parent eafc956 commit c35aac5

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/traces/indicator/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
6464
}
6565
coerce('delta.reference', traceOut.value);
6666
coerce('delta.relative');
67-
coerce('delta.valueformat', traceOut.delta.relative ? '2%' : '');
67+
coerce('delta.valueformat', traceOut.delta.relative ? '.0%' : '');
6868
coerce('delta.increasing.symbol');
6969
coerce('delta.increasing.color');
7070
coerce('delta.decreasing.symbol');

test/jasmine/tests/indicator_test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('Indicator defaults', function() {
4848

4949
it('defaults to displaying relative changes in percentage', function() {
5050
var out = _supply({type: 'indicator', mode: 'delta', delta: {relative: true}, value: 1});
51-
expect(out.delta.valueformat).toBe('2%');
51+
expect(out.delta.valueformat).toBe('.0%');
5252
});
5353

5454
it('should not ignore empty valueformat', function() {
@@ -164,7 +164,7 @@ describe('Indicator plot', function() {
164164
Plotly.newPlot(gd, [{
165165
type: 'indicator',
166166
value: 500,
167-
number: {valueformat: '0.f'}
167+
number: {valueformat: '~f'}
168168
}], {width: 400, height: 400})
169169
.then(function() {
170170
checkNumbersScale(1, 'initialy at normal scale');
@@ -185,7 +185,7 @@ describe('Indicator plot', function() {
185185
Plotly.newPlot(gd, [{
186186
type: 'indicator',
187187
value: 1,
188-
number: {valueformat: '0.f'}
188+
number: {valueformat: '~f'}
189189
}], {width: 400, height: 400})
190190
.then(function() {
191191
checkNumbersScale(1, 'initialy at normal scale');
@@ -208,7 +208,7 @@ describe('Indicator plot', function() {
208208
type: 'indicator',
209209
mode: 'number+delta',
210210
value: 1,
211-
number: {valueformat: '0.f'}
211+
number: {valueformat: '~f'}
212212
};
213213
figure[numberType] = {font: {size: 100}};
214214
Plotly.newPlot(gd, [figure], {width: 400, height: 400})

0 commit comments

Comments
 (0)