Skip to content

Commit c1ad7d0

Browse files
committed
throw axis scaling error when ax._length or ax._offset are negative
- which happens currently in #3600 - should make debugging easier
1 parent 1f6e711 commit c1ad7d0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/plots/cartesian/set_convert.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -484,15 +484,14 @@ module.exports = function setConvert(ax, fullLayout) {
484484
ax._length = gs.h * (ax.domain[1] - ax.domain[0]);
485485
ax._m = ax._length / (rl0 - rl1);
486486
ax._b = -ax._m * rl1;
487-
}
488-
else {
487+
} else {
489488
ax._offset = gs.l + ax.domain[0] * gs.w;
490489
ax._length = gs.w * (ax.domain[1] - ax.domain[0]);
491490
ax._m = ax._length / (rl1 - rl0);
492491
ax._b = -ax._m * rl0;
493492
}
494493

495-
if(!isFinite(ax._m) || !isFinite(ax._b)) {
494+
if(!isFinite(ax._m) || !isFinite(ax._b) || ax._length < 0 || ax._offset < 0) {
496495
fullLayout._replotting = false;
497496
throw new Error('Something went wrong with axis scaling');
498497
}

0 commit comments

Comments
 (0)