rename function argument to hideZeroSpan

archmoj · archmoj · commit beb9d8874bde · 2020-01-28T15:35:37.000-05:00
diff --git a/src/traces/bar/plot.js b/src/traces/bar/plot.js
@@ -191,8 +191,8 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts, makeOnCompleteCallback)
                     d3.round(Math.round(v) - offset, 2) : v;
             }
 
-            function expandToVisible(v, vc, hideZeroHeight) {
-                if(hideZeroHeight && v === vc) return v;
+            function expandToVisible(v, vc, hideZeroSpan) {
+                if(hideZeroSpan && v === vc) return v;
 
                 // if it's not in danger of disappearing entirely,
                 // round more precisely

Original file line number	Diff line number	Diff line change
`@@ -191,8 +191,8 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts, makeOnCompleteCallback)`
`191`	`191`	`d3.round(Math.round(v) - offset, 2) : v;`
`192`	`192`	`}`
`193`	`193`
`194`		`- function expandToVisible(v, vc, hideZeroHeight) {`
`195`		`- if(hideZeroHeight && v === vc) return v;`
	`194`	`+ function expandToVisible(v, vc, hideZeroSpan) {`
	`195`	`+ if(hideZeroSpan && v === vc) return v;`
`196`	`196`
`197`	`197`	`// if it's not in danger of disappearing entirely,`
`198`	`198`	`// round more precisely`