Skip to content

Commit bc99323

Browse files
committed
Add test for supplyTransformDefaults
1 parent 9b858a6 commit bc99323

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

src/plots/plots.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -824,13 +824,13 @@ plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInInde
824824
coerce('legendgroup');
825825
}
826826

827-
supplyTransformDefaults(traceIn, traceOut, layout);
827+
plots.supplyTransformDefaults(traceIn, traceOut, layout);
828828
}
829829

830830
return traceOut;
831831
};
832832

833-
function supplyTransformDefaults(traceIn, traceOut, layout) {
833+
plots.supplyTransformDefaults = function(traceIn, traceOut, layout) {
834834
var globalTransforms = layout._globalTransforms || [];
835835
var transformModules = layout._transformModules || [];
836836

@@ -861,7 +861,7 @@ function supplyTransformDefaults(traceIn, traceOut, layout) {
861861

862862
containerOut.push(transformOut);
863863
}
864-
}
864+
};
865865

866866
function applyTransforms(fullTrace, fullData, layout, fullLayout) {
867867
var container = fullTrace.transforms,

test/jasmine/tests/plots_test.js

+14
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,20 @@ describe('Test Plots', function() {
240240
});
241241
});
242242

243+
describe('Plots.supplyTransformDefaults', function() {
244+
it('should accept an empty layout when transforms present', function() {
245+
var traceOut = {};
246+
Plots.supplyTransformDefaults({}, traceOut, {
247+
_globalTransforms: [{ type: 'filter'}]
248+
});
249+
250+
// This isn't particularly interseting. More relevant is that
251+
// the above supplyTransformDefaults call didn't fail due to
252+
// missing transformModules data.
253+
expect(traceOut.transforms.length).toEqual(1);
254+
});
255+
});
256+
243257
describe('Plots.getSubplotIds', function() {
244258
var getSubplotIds = Plots.getSubplotIds;
245259

0 commit comments

Comments
 (0)