Skip to content

Commit b942832

Browse files
committed
indicator: remove + sign by default
1 parent 8cea8e7 commit b942832

File tree

10 files changed

+6
-6
lines changed

10 files changed

+6
-6
lines changed

src/traces/indicator/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
6565
coerce('delta.reference', traceOut.value);
6666
coerce('delta.relative');
6767
coerce('delta.valueformat');
68-
if(!traceOut.delta.valueformat) traceOut.delta.valueformat = traceOut.delta.relative ? '+2%' : '+.3s';
68+
if(!traceOut.delta.valueformat) traceOut.delta.valueformat = traceOut.delta.relative ? '2%' : '.3s';
6969
coerce('delta.increasing.symbol');
7070
coerce('delta.increasing.color');
7171
coerce('delta.decreasing.symbol');
76 Bytes
Loading
-149 Bytes
Loading
63 Bytes
Loading
838 Bytes
Loading
832 Bytes
Loading
1.2 KB
Loading
1.24 KB
Loading
-434 Bytes
Loading

test/jasmine/tests/indicator_test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,17 @@ describe('Indicator defaults', function() {
4242
it('defaults to formatting numbers using SI prefix', function() {
4343
var out = _supply({type: 'indicator', mode: 'number+delta', value: 1});
4444
expect(out.number.valueformat).toBe('.3s');
45-
expect(out.delta.valueformat).toBe('+.3s');
45+
expect(out.delta.valueformat).toBe('.3s');
4646
});
4747

4848
it('defaults to displaying relative changes in percentage', function() {
4949
var out = _supply({type: 'indicator', mode: 'delta', delta: {relative: true}, value: 1});
50-
expect(out.delta.valueformat).toBe('+2%');
50+
expect(out.delta.valueformat).toBe('2%');
5151
});
5252

5353
it('ignores empty valueformat', function() {
5454
var out = _supply({type: 'indicator', mode: 'number+delta', number: {valueformat: ''}, delta: {valueformat: ''}, value: 1});
55-
expect(out.delta.valueformat).toBe('+.3s');
55+
expect(out.delta.valueformat).toBe('.3s');
5656
expect(out.number.valueformat).toBe('.3s');
5757
});
5858

@@ -298,11 +298,11 @@ describe('Indicator plot', function() {
298298
delta: {reference: 200}
299299
}], {width: 400, height: 400})
300300
.then(function() {
301-
assertContent(gd._fullData[0].delta.increasing.symbol + '+20.0');
301+
assertContent(gd._fullData[0].delta.increasing.symbol + '20.0');
302302
return Plotly.restyle(gd, 'delta.relative', true);
303303
})
304304
.then(function() {
305-
assertContent(gd._fullData[0].delta.increasing.symbol + '+10%');
305+
assertContent(gd._fullData[0].delta.increasing.symbol + '10%');
306306
return Plotly.restyle(gd, 'delta.valueformat', '.3f');
307307
})
308308
.then(function() {

0 commit comments

Comments
 (0)