Merge pull request #3789 from plotly/fix3787-waterfall-line-width-react-in-mode-between

Waterfall connector.line.width react bug in mode between

Author: archmoj

Diff for: src/traces/waterfall/attributes.js

@@ -96,7 +96,9 @@ module.exports = {
     connector: {
         line: {
             color: extendFlat({}, lineAttrs.color, {dflt: Color.defaultLine}),
-            width: lineAttrs.width,
+            width: extendFlat({}, lineAttrs.width, {
+                editType: 'plot', // i.e. to adjust bars is mode: 'between'. See https://github.com/plotly/plotly.js/issues/3787
+            }),
             dash: lineAttrs.dash,
             editType: 'plot'
         },

Diff for: test/jasmine/tests/waterfall_test.js

@@ -1140,6 +1140,41 @@ describe('A waterfall plot', function() {
         .catch(failTest)
         .then(done);
     });
+
+    it('should be able to adjust bars when reacting with new connector.line.width ', function(done) {
+        Plotly.plot(gd, {
+            data: [{
+                type: 'waterfall',
+                y: [1, 2, 3],
+            }],
+            layout: {
+                width: 500,
+                height: 500
+            }
+        })
+        .then(function() {
+            var traceNodes = getAllTraceNodes(gd);
+            var waterfallNodes = getAllWaterfallNodes(traceNodes[0]);
+            var path = waterfallNodes[0].querySelector('path');
+            var d = d3.select(path).attr('d');
+            expect(d).toBe('M11.33,321V268.33H102V321Z');
+        })
+        .then(function() {
+            gd.data[0].connector = {
+                line: { width: 10 }
+            };
+            return Plotly.react(gd, gd.data);
+        })
+        .then(function() {
+            var traceNodes = getAllTraceNodes(gd);
+            var waterfallNodes = getAllWaterfallNodes(traceNodes[0]);
+            var path = waterfallNodes[0].querySelector('path');
+            var d = d3.select(path).attr('d');
+            expect(d).toBe('M11.33,325V264.33H102V325Z');
+        })
+        .catch(failTest)
+        .then(done);
+    });
 });
 
 describe('waterfall visibility toggling:', function() {