🔪 obsolete sortBasePlotModules

... no need for this now that we have redrawReglTraces

Author: etpinard

src/plots/plots.js

@@ -20,7 +20,6 @@ var Color = require('../components/color');
 var BADNUM = require('../constants/numerical').BADNUM;
 
 var axisIDs = require('../plots/cartesian/axis_ids');
-var sortBasePlotModules = require('./sort_modules').sortBasePlotModules;
 
 var animationAttrs = require('./animation_attributes');
 var frameAttrs = require('./frame_attributes');
@@ -487,9 +486,6 @@ plots.supplyDefaults = function(gd, opts) {
     if(!skipUpdateCalc && oldCalcdata.length === newFullData.length) {
         plots.supplyDefaultsUpdateCalc(oldCalcdata, newFullData);
     }
-
-    // sort base plot modules for consistent ordering
-    newFullLayout._basePlotModules.sort(sortBasePlotModules);
 };
 
 plots.supplyDefaultsUpdateCalc = function(oldCalcdata, newFullData) {

src/plots/sort_modules.js

@@ -153,26 +153,6 @@ describe('Test Plots', function() {
 
             testSanitizeMarginsHasBeenCalledOnlyOnce(gd);
         });
-
-        it('should sort base plot modules on fullLayout object', function() {
-            var gd = Lib.extendDeep({}, require('@mocks/plot_types.json'));
-            gd.data.unshift({type: 'scattergl'});
-            gd.data.push({type: 'splom'});
-
-            supplyAllDefaults(gd);
-            var names = gd._fullLayout._basePlotModules.map(function(m) {
-                return m.name;
-            });
-
-            expect(names).toEqual([
-                'splom',
-                'cartesian',
-                'gl3d',
-                'geo',
-                'pie',
-                'ternary'
-            ]);
-        });
     });
 
     describe('Plots.supplyLayoutGlobalDefaults should', function() {