Skip to content

Commit b249f7b

Browse files
committed
Remove unexposed cascade option
1 parent a36fb6e commit b249f7b

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/components/drawing/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ drawing.translatePoints = function(s, xa, ya, trace, transitionConfig, joinDirec
6969
var trans;
7070
if(!joinDirection) {
7171
trans = p.transition()
72-
.delay(transitionConfig.delay + transitionConfig.cascade / size * i)
72+
.delay(transitionConfig.delay)
7373
.duration(transitionConfig.duration)
7474
.ease(transitionConfig.ease)
7575
.attr('transform', 'translate(' + x + ',' + y + ')');

src/plot_api/plot_api.js

+9-4
Original file line numberDiff line numberDiff line change
@@ -2651,7 +2651,7 @@ Plotly.transition = function(gd, data, layout, traceIndices, transitionConfig) {
26512651
basePlotModules[j].plot(gd, transitionedTraces, traceTransitionConfig);
26522652
}
26532653

2654-
gd._transitionData._completionTimeout = setTimeout(completeTransition, transitionConfig.duration + transitionConfig.delay);
2654+
gd._transitionData._completionTimeout = setTimeout(completeTransition, transitionConfig.duration + transitionConfig.delay + 1000);
26552655

26562656
if(!hasAxisTransition && !hasTraceTransition) {
26572657
return false;
@@ -2661,9 +2661,14 @@ Plotly.transition = function(gd, data, layout, traceIndices, transitionConfig) {
26612661
function completeTransition() {
26622662
flushCallbacks(gd._transitionData._interruptCallbacks);
26632663

2664-
gd.emit('plotly_endtransition', []);
2665-
2666-
return executeCallbacks(gd._transitionData._cleanupCallbacks);
2664+
return Promise.resolve().then(function () {
2665+
if (transitionConfig.redraw) {
2666+
return Plotly.redraw(gd);
2667+
}
2668+
}).then(function () {
2669+
gd.emit('plotly_endtransition', []);
2670+
return executeCallbacks(gd._transitionData._cleanupCallbacks);
2671+
});
26672672
}
26682673

26692674
function interruptPreviousTransitions() {

0 commit comments

Comments
 (0)