Skip to content

Commit ade3cca

Browse files
committed
review comments - 🔪 commented-out code, comment on cleanData
1 parent 88ad7f2 commit ade3cca

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/plot_api/helpers.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,14 @@ function cleanAxRef(container, attr) {
196196
}
197197
}
198198

199-
// Make a few changes to the data right away
200-
// before it gets used for anything
199+
/*
200+
* cleanData: Make a few changes to the data right away
201+
* before it gets used for anything
202+
* Mostly for backward compatibility, modifies the data traces users provide.
203+
*
204+
* Important: if you're going to add something here that modifies a data array,
205+
* update it in place so the new array === the old one.
206+
*/
201207
exports.cleanData = function(data, existingData) {
202208
// Enforce unique IDs
203209
var suids = [], // seen uids --- so we can weed out incoming repeats

src/plots/gl3d/layout/tick_marks.js

-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ function computeTickMarks(scene) {
7878

7979

8080
axes.tickmode = tickModeCached;
81-
// axes.range = rangeCached;
8281
}
8382
}
8483

0 commit comments

Comments
 (0)