Skip to content

Commit aa6f442

Browse files
authored
Merge pull request #5293 from plotly/fix5289-gcc
Set false locale
2 parents 4afc441 + 0a21710 commit aa6f442

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/plots/plots.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ function emptySubplotLists() {
667667
*/
668668
function getFormatObj(gd, formatKeys) {
669669
var locale = gd._context.locale;
670-
if(!locale) locale === 'en-US';
670+
if(!locale) locale = 'en-US';
671671

672672
var formatDone = false;
673673
var formatObj = {};

src/traces/histogram/cross_trace_defaults.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,9 @@ module.exports = function crossTraceDefaults(fullData, fullLayout) {
174174
}
175175

176176
var binGroupFound = false;
177-
for(i = 0; i < traces.length; i++) {
178-
traceOut = traces[i];
177+
if(traces.length) {
178+
traceOut = traces[0];
179179
binGroupFound = coerce('bingroup');
180-
break;
181180
}
182181

183182
groupName = binGroupFound || groupName;

0 commit comments

Comments
 (0)