implement cartesian axis for parcoords and change parcoords tickformat default to be on par with cartesian axes

Author: archmoj

src/traces/parcoords/attributes.js

@@ -81,18 +81,9 @@ module.exports = {
                 'Sets the text displayed at the ticks position via `tickvals`.'
             ].join(' ')
         }),
-        tickformat: {
-            valType: 'string',
-            dflt: '3s',
-            noBlank: true,
-            role: 'style',
-            editType: 'plot',
-            description: [
-                'Sets the tick label formatting rule using d3 formatting mini-language',
-                'which is similar to those of Python. See',
-                'https://github.com/d3/d3-format/blob/master/README.md#locale_format'
-            ].join(' ')
-        },
+        tickformat: extendFlat({}, axesAttrs.tickformat, {
+            editType: 'plot'
+        }),
         visible: {
             valType: 'boolean',
             dflt: true,

src/traces/parcoords/defaults.js

@@ -13,6 +13,8 @@ var hasColorscale = require('../../components/colorscale/helpers').hasColorscale
 var colorscaleDefaults = require('../../components/colorscale/defaults');
 var handleDomainDefaults = require('../../plots/domain').defaults;
 var handleArrayContainerDefaults = require('../../plots/array_container_defaults');
+var Axes = require('../../plots/cartesian/axes');
+var axesAttrs = require('../../plots/cartesian/layout_attributes');
 
 var attributes = require('./attributes');
 var axisBrush = require('./axisbrush');
@@ -37,11 +39,15 @@ function handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
     return Infinity;
 }
 
-function dimensionDefaults(dimensionIn, dimensionOut) {
+function dimensionDefaults(dimensionIn, dimensionOut, parentOut, opts) {
     function coerce(attr, dflt) {
         return Lib.coerce(dimensionIn, dimensionOut, attributes.dimensions, attr, dflt);
     }
 
+    function axCoerce(attr, dflt) {
+        return Lib.coerce(dimensionIn, dimensionOut._ax, axesAttrs, attr, dflt);
+    }
+
     var values = coerce('values');
     var visible = coerce('visible');
     if(!(values && values.length)) {
@@ -53,7 +59,18 @@ function dimensionDefaults(dimensionIn, dimensionOut) {
         coerce('tickvals');
         coerce('ticktext');
         coerce('tickformat');
-        coerce('range');
+
+        dimensionOut._ax = {
+            _id: 'y',
+            type: 'linear',
+            showexponent: 'all',
+            exponentformat: 'B'
+        };
+
+        Axes.setConvert(dimensionOut._ax, opts.layout);
+
+        axCoerce('range');
+        dimensionOut.range = dimensionOut._ax.range;
 
         coerce('multiselect');
         var constraintRange = coerce('constraintrange');
@@ -76,6 +93,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     var dimensions = handleArrayContainerDefaults(traceIn, traceOut, {
         name: 'dimensions',
+        layout: layout,
         handleItemDefaults: dimensionDefaults
     });
 

src/traces/parcoords/parcoords.js

@@ -378,22 +378,22 @@ function updatePanelLayout(yAxis, vm) {
     }
 }
 
-function attachAxesToCd(cd, fullLayout) {
+function calcAllTicks(cd) {
     for(var i = 0; i < cd.length; i++) {
         for(var j = 0; j < cd[i].length; j++) {
             var dimensions = cd[i][j].trace.dimensions;
-
             for(var k = 0; k < dimensions.length; k++) {
-                var dim = dimensions[k];
+                var dim = dimensions[k]._ax;
 
-                dim._ax = {
-                    type: 'linear',
-                    showexponent: 'all',
-                    exponentformat: 'B',
-                    tickformat: dim.tickformat
-                };
+                if(dim) {
+                    if(!dim.range) dim.range = [0, 1];
+                    if(!dim.dtick) dim.dtick = 0.1;
+                    dim.tickformat = dimensions[k].tickformat;
+
+                    Axes.calcTicks(dim);
 
-                Axes.setConvert(dim._ax, fullLayout);
+                    dim.cleanRange();
+                }
             }
         }
     }
@@ -406,8 +406,6 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
     var svg = fullLayout._toppaper;
     var glContainer = fullLayout._glcontainer;
 
-    attachAxesToCd(cdModule, fullLayout);
-
     function linearFormat(dim, v) {
         return Axes.tickText(dim._ax, v, false).text;
     }
@@ -420,6 +418,8 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
         return linearFormat(d.model.dimensions[d.visibleIndex], v);
     }
 
+    calcAllTicks(cdModule);
+
     var vm = cdModule
         .filter(function(d) { return unwrap(d).trace.visible; })
         .map(model.bind(0, layout))

test/image/baselines/gl2d_parcoords.png

@@ -165,7 +165,7 @@ describe('parcoords initialization tests', function() {
             expect(fullTrace.dimensions).toEqual([jasmine.objectContaining({
                 values: [1],
                 visible: true,
-                tickformat: '3s',
+                tickformat: '',
                 multiselect: true,
                 _index: 0,
                 _length: 1