Merge pull request #1766 from plotly/gl2d-better-ticks

gl2d better ticks

Author: etpinard

src/plots/gl2d/scene2d.js

@@ -259,13 +259,6 @@ proto.computeTickMarks = function() {
     this.xaxis.setScale();
     this.yaxis.setScale();
 
-    // override _length from backward compatibility
-    // even though setScale 'should' give the correct result
-    this.xaxis._length =
-        this.glplot.viewBox[2] - this.glplot.viewBox[0];
-    this.yaxis._length =
-        this.glplot.viewBox[3] - this.glplot.viewBox[1];
-
     var nextTicks = [
         Axes.calcTicks(this.xaxis),
         Axes.calcTicks(this.yaxis)

test/image/baselines/gl2d_10.png

@@ -224,7 +224,7 @@ describe('Test hover and click interactions', function() {
             bordercolor: _mock.data[0].x.map(function(_, i) { return i % 2 ? 'red' : 'green'; })
         };
 
-        var run = makeRunner([655, 317], {
+        var run = makeRunner([634, 321], {
             x: 15.772,
             y: 0.387,
             label: ['0.387'],
@@ -249,7 +249,7 @@ describe('Test hover and click interactions', function() {
         var _mock = Lib.extendDeep({}, mock1);
         _mock.data[0].hoverinfo = 'none';
 
-        var run = makeRunner([655, 317], {
+        var run = makeRunner([634, 321], {
             x: 15.772,
             y: 0.387,
             curveNumber: 0,

test/image/baselines/gl2d_12.png

@@ -826,10 +826,10 @@ describe('Test gl2d plots', function() {
         var _mock = Lib.extendDeep({}, mock);
         var relayoutCallback = jasmine.createSpy('relayoutCallback');
 
-        var originalX = [-0.022068095838587643, 5.022068095838588];
-        var originalY = [-0.21331533513634046, 5.851205650049042];
-        var newX = [-0.23224043715846995, 4.811895754518705];
-        var newY = [-1.2962655110623016, 4.768255474123081];
+        var originalX = [-0.3037383177570093, 5.303738317757009];
+        var originalY = [-0.5532219548705213, 6.191112269783224];
+        var newX = [-0.5373831775700935, 5.070093457943925];
+        var newY = [-1.7575673521301187, 4.986766872523626];
         var precision = 5;
 
         Plotly.plot(gd, _mock)
@@ -1326,10 +1326,10 @@ describe('Test gl2d interactions', function() {
             dragmode: 'pan'
         })
         .then(function() {
-            assertAnnotation([327, 325]);
+            assertAnnotation([327, 315]);
 
             drag([250, 200], [200, 150]);
-            assertAnnotation([277, 275]);
+            assertAnnotation([277, 265]);
 
             return Plotly.relayout(gd, {
                 'xaxis.range': [1.5, 2.5],