Skip to content

Commit a5fa247

Browse files
committed
legend: minor style improvements to the code
1 parent 131145d commit a5fa247

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/components/legend/draw.js

+6-7
Original file line numberDiff line numberDiff line change
@@ -594,31 +594,30 @@ function computeLegendDimensions(gd, groups, traces) {
594594

595595
var maxItems = 0;
596596

597-
groupData.forEach(function(group) {
598-
599-
597+
var i;
598+
for(i = 0; i < groupData.length; i++) {
599+
var group = groupData[i];
600600
var groupWidths = group.map(function(legendItemArray) {
601601
return legendItemArray[0].width;
602602
});
603603

604-
var groupWidth = Math.max.apply(null, groupWidths);
604+
var groupWidth = Lib.aggNums(Math.max, null, groupWidths);
605605
var groupHeight = group.reduce(function(a, b) {
606606
return a + b[0].height;
607607
}, 0);
608608

609609
maxWidth = Math.max(maxWidth, groupWidth);
610610
maxHeight = Math.max(maxHeight, groupHeight);
611611
maxItems = Math.max(maxItems, group.length);
612-
});
612+
}
613613

614614
maxWidth += traceGap;
615615
maxWidth += 40;
616616

617617
var groupXOffsets = [opts._width];
618618
var groupYOffsets = [];
619619
var rowNum = 0;
620-
for(var i = 0, n = groupData.length; i < n; i++) {
621-
620+
for(i = 0; i < groupData.length; i++) {
622621
if(fullLayout._size.w < (borderwidth + opts._width + traceGap + maxWidth)) {
623622
groupXOffsets[groupXOffsets.length - 1] = groupXOffsets[0];
624623
opts._width = maxWidth;

0 commit comments

Comments
 (0)