remove jQuery from tests

Author: archmoj

test/jasmine/assets/jquery-1.8.3.min.js

@@ -117,7 +117,6 @@ if(isFullSuite) {
     testFileGlob = path.join(__dirname, 'tests', glob(merge(argv._).map(basename)));
 }
 
-var pathToJQuery = path.join(__dirname, 'assets', 'jquery-1.8.3.min.js');
 var pathToCustomMatchers = path.join(__dirname, 'assets', 'custom_matchers.js');
 var pathToUnpolyfill = path.join(__dirname, 'assets', 'unpolyfill.js');
 var pathToSaneTopojsonDist = path.join(__dirname, '..', '..', 'node_modules', 'sane-topojson', 'dist');
@@ -318,10 +317,6 @@ func.defaultConfig = {
 func.defaultConfig.preprocessors[pathToCustomMatchers] = ['esbuild'];
 func.defaultConfig.preprocessors[testFileGlob] = ['esbuild'];
 
-if(!isBundleTest) {
-    func.defaultConfig.files.push(pathToJQuery);
-}
-
 if(argv.virtualWebgl) {
     // add virtual-webgl to the top
     func.defaultConfig.files = [

test/jasmine/karma.conf.js

@@ -1,11 +1,3 @@
-/* global $:false, jQuery:false */
-
-/*
- * Note this test requires JQuery in the global scope.
- * we should keep it that way to keep testing our backward
- * compatibility with JQuery events.
- */
-
 var Events = require('../../../src/lib/events');
 
 describe('Events', function() {
@@ -57,19 +49,6 @@ describe('Events', function() {
             });
         });
 
-        it('triggers jquery events', function(done) {
-            Events.init(plotDiv);
-
-            $(plotDiv).bind('ping', function(event, data) {
-                expect(data).toBe('pong');
-                done();
-            });
-
-            setTimeout(function() {
-                $(plotDiv).trigger('ping', 'pong');
-            });
-        });
-
         it('mirrors events on an internal handler', function(done) {
             Events.init(plotDiv);
 
@@ -139,86 +118,6 @@ describe('Events', function() {
             expect(result).toBe('pong');
         });
 
-        it('triggers jQuery handlers when no matching node events bound', function() {
-            var eventBaton = 0;
-
-            Events.init(plotDiv);
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            /*
-             * This will not be called
-             */
-            plotDiv.on('pong', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'pong';
-            });
-
-            var result = Events.triggerHandler(plotDiv, 'ping');
-
-            expect(eventBaton).toBe(2);
-            expect(result).toBe('pong');
-        });
-
-        it('triggers jQuery handlers when no node events initialized', function() {
-            var eventBaton = 0;
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'pong';
-            });
-
-            var result = Events.triggerHandler(plotDiv, 'ping');
-
-            expect(eventBaton).toBe(3);
-            expect(result).toBe('pong');
-        });
-
-
-        it('triggers jQuery + nodejs handlers and returns last jQuery value', function() {
-            var eventBaton = 0;
-
-            Events.init(plotDiv);
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            plotDiv.on('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            $(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'pong';
-            });
-
-            var result = Events.triggerHandler(plotDiv, 'ping');
-
-            expect(eventBaton).toBe(3);
-            expect(result).toBe('pong');
-        });
-
         it('works with *once* event handlers', function() {
             var eventBaton = 0;
 
@@ -247,106 +146,4 @@ describe('Events', function() {
             expect(plotObj).toEqual({});
         });
     });
-
-    describe('when jQuery.noConflict is set, ', function() {
-        beforeEach(function() {
-            $.noConflict();
-        });
-
-        afterEach(function() {
-            window.$ = jQuery;
-        });
-
-        it('triggers jquery events', function(done) {
-            Events.init(plotDiv);
-
-            jQuery(plotDiv).bind('ping', function(event, data) {
-                expect(data).toBe('pong');
-                done();
-            });
-
-            setTimeout(function() {
-                jQuery(plotDiv).trigger('ping', 'pong');
-            });
-        });
-
-        it('triggers jQuery handlers when no matching node events bound', function() {
-            var eventBaton = 0;
-
-            Events.init(plotDiv);
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            /*
-             * This will not be called
-             */
-            plotDiv.on('pong', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'pong';
-            });
-
-            var result = Events.triggerHandler(plotDiv, 'ping');
-
-            expect(eventBaton).toBe(2);
-            expect(result).toBe('pong');
-        });
-
-        it('triggers jQuery handlers when no node events initialized', function() {
-            var eventBaton = 0;
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'pong';
-            });
-
-            var result = Events.triggerHandler(plotDiv, 'ping');
-
-            expect(eventBaton).toBe(3);
-            expect(result).toBe('pong');
-        });
-
-        it('triggers jQuery + nodejs handlers and returns last jQuery value', function() {
-            var eventBaton = 0;
-
-            Events.init(plotDiv);
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            plotDiv.on('ping', function() {
-                eventBaton++;
-                return 'ping';
-            });
-
-            jQuery(plotDiv).bind('ping', function() {
-                eventBaton++;
-                return 'pong';
-            });
-
-            var result = Events.triggerHandler(plotDiv, 'ping');
-
-            expect(eventBaton).toBe(3);
-            expect(result).toBe('pong');
-        });
-    });
 });