Skip to content

Commit 9d3776e

Browse files
committed
remove 'fill' and 'fillcolor' (for now):
- scatterternary fill will be part of the next iteration
1 parent a043655 commit 9d3776e

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

src/traces/scatterternary/attributes.js

-5
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@ module.exports = {
8080
smoothing: scatterLineAttrs.smoothing
8181
},
8282
connectgaps: scatterAttrs.connectgaps,
83-
fill: extendFlat({}, scatterAttrs.fill, {
84-
values: ['none', 'tozeroa', 'tozerob', 'tozeroc',
85-
'tonexta', 'tonextb', 'tonextc']
86-
}),
87-
fillcolor: scatterAttrs.fillcolor,
8883
marker: {
8984
symbol: scatterMarkerAttrs.symbol,
9085
opacity: scatterMarkerAttrs.opacity,

src/traces/scatterternary/defaults.js

+3-7
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ var handleMarkerDefaults = require('../scatter/marker_defaults');
1717
var handleLineDefaults = require('../scatter/line_defaults');
1818
var handleLineShapeDefaults = require('../scatter/line_shape_defaults');
1919
var handleTextDefaults = require('../scatter/text_defaults');
20-
var handleFillColorDefaults = require('../scatter/fillcolor_defaults');
2120

2221
var attributes = require('./attributes');
2322

@@ -85,11 +84,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
8584
coerce('marker.maxdisplayed');
8685
}
8786

88-
coerce('fill');
89-
if(traceOut.fill !== 'none') {
90-
handleFillColorDefaults(traceIn, traceOut, defaultColor, coerce);
91-
if(!subTypes.hasLines(traceOut)) handleLineShapeDefaults(traceIn, traceOut, coerce);
92-
}
93-
9487
coerce('hoverinfo', (layout._dataLength === 1) ? 'a+b+c+text' : undefined);
88+
89+
// until 'fill' and 'fillcolor' are supported
90+
traceOut.fill = 'none';
9591
};

0 commit comments

Comments
 (0)