Skip to content

Commit 9ba5c96

Browse files
committed
refactor long if statement
1 parent 580b819 commit 9ba5c96

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

src/plots/gl3d/scene.js

+6-10
Original file line numberDiff line numberDiff line change
@@ -748,18 +748,14 @@ proto.plot = function(sceneData, fullLayout, layout) {
748748
if(aspectmode === 'data') {
749749
aspectRatio = axesScaleRatio;
750750
} else { // i.e. 'auto' option
751-
var axisAutoScaleFactor = 4;
752-
753-
if(Math.max.apply(null, axesScaleRatio) / Math.min.apply(null, axesScaleRatio) <= axisAutoScaleFactor) {
754-
/*
755-
* USE DATA MODE WHEN AXIS RANGE DIMENSIONS ARE RELATIVELY EQUAL
756-
*/
757-
751+
if(
752+
Math.max.apply(null, axesScaleRatio) /
753+
Math.min.apply(null, axesScaleRatio) <= 4
754+
) {
755+
// USE DATA MODE WHEN AXIS RANGE DIMENSIONS ARE RELATIVELY EQUAL
758756
aspectRatio = axesScaleRatio;
759757
} else {
760-
/*
761-
* USE EQUAL MODE WHEN AXIS RANGE DIMENSIONS ARE HIGHLY UNEQUAL
762-
*/
758+
// USE EQUAL MODE WHEN AXIS RANGE DIMENSIONS ARE HIGHLY UNEQUAL
763759
aspectRatio = [1, 1, 1];
764760
}
765761
}

0 commit comments

Comments
 (0)