Skip to content

Commit 9753fb9

Browse files
archmojarchmoj
committed
drop many flaky flags
1 parent 149701e commit 9753fb9

8 files changed

+79
-79
lines changed

‎test/jasmine/tests/animate_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ describe('Animating multiple axes', function() {
719719
destroyGraphDiv();
720720
});
721721

722-
it('@flaky updates ranges of secondary axes', function(done) {
722+
it('updates ranges of secondary axes', function(done) {
723723
Plotly.plot(gd, [
724724
{y: [1, 2, 3]},
725725
{y: [1, 2, 3], yaxis: 'y2'}
@@ -750,7 +750,7 @@ describe('Animating multiple axes', function() {
750750
.then(done);
751751
});
752752

753-
it('@flaky updates ranges of secondary axes (date + category case)', function(done) {
753+
it('updates ranges of secondary axes (date + category case)', function(done) {
754754
Plotly.plot(gd, [
755755
{x: ['2018-01-01', '2019-01-01', '2020-01-01'], y: [1, 2, 3]},
756756
{x: ['a', 'b', 'c'], y: [1, 2, 3], xaxis: 'x2', yaxis: 'y2'}

‎test/jasmine/tests/config_test.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -681,15 +681,15 @@ describe('config argument', function() {
681681
gd = parent.childNodes[0];
682682
}
683683

684-
it('@flaky should resize when the viewport width/height changes', function(done) {
684+
it('should resize when the viewport width/height changes', function(done) {
685685
fillParent(1, 1);
686686
Plotly.plot(gd, data, {}, {responsive: true})
687687
.then(testResponsive)
688688
.catch(failTest)
689689
.then(done);
690690
});
691691

692-
it('@flaky should still be responsive if the plot is edited', function(done) {
692+
it('should still be responsive if the plot is edited', function(done) {
693693
fillParent(1, 1);
694694
Plotly.plot(gd, data, {}, {responsive: true})
695695
.then(function() {return Plotly.restyle(gd, 'y[0]', data[0].y[0] + 2);})
@@ -698,7 +698,7 @@ describe('config argument', function() {
698698
.then(done);
699699
});
700700

701-
it('@flaky should still be responsive if the plot is purged and replotted', function(done) {
701+
it('should still be responsive if the plot is purged and replotted', function(done) {
702702
fillParent(1, 1);
703703
Plotly.plot(gd, data, {}, {responsive: true})
704704
.then(function() {return Plotly.newPlot(gd, data, {}, {responsive: true});})
@@ -707,7 +707,7 @@ describe('config argument', function() {
707707
.then(done);
708708
});
709709

710-
it('@flaky should only have one resize handler when plotted more than once', function(done) {
710+
it('should only have one resize handler when plotted more than once', function(done) {
711711
fillParent(1, 1);
712712
var cntWindowResize = 0;
713713
window.addEventListener('resize', function() {cntWindowResize++;});
@@ -726,7 +726,7 @@ describe('config argument', function() {
726726
.then(done);
727727
});
728728

729-
it('@flaky should become responsive if configured as such via Plotly.react', function(done) {
729+
it('should become responsive if configured as such via Plotly.react', function(done) {
730730
fillParent(1, 1);
731731
Plotly.plot(gd, data, {}, {responsive: false})
732732
.then(function() {return Plotly.react(gd, data, {}, {responsive: true});})
@@ -735,7 +735,7 @@ describe('config argument', function() {
735735
.then(done);
736736
});
737737

738-
it('@flaky should stop being responsive if configured as such via Plotly.react', function(done) {
738+
it('should stop being responsive if configured as such via Plotly.react', function(done) {
739739
fillParent(1, 1);
740740
Plotly.plot(gd, data, {}, {responsive: true})
741741
// Check initial size
@@ -753,7 +753,7 @@ describe('config argument', function() {
753753
});
754754

755755
// Testing fancier CSS layouts
756-
it('@flaky should resize horizontally in a flexbox when responsive: true', function(done) {
756+
it('should resize horizontally in a flexbox when responsive: true', function(done) {
757757
parent.style.display = 'flex';
758758
parent.style.flexDirection = 'row';
759759
fillParent(1, 2, function() {
@@ -766,7 +766,7 @@ describe('config argument', function() {
766766
.then(done);
767767
});
768768

769-
it('@flaky should resize vertically in a flexbox when responsive: true', function(done) {
769+
it('should resize vertically in a flexbox when responsive: true', function(done) {
770770
parent.style.display = 'flex';
771771
parent.style.flexDirection = 'column';
772772
fillParent(2, 1, function() {
@@ -779,7 +779,7 @@ describe('config argument', function() {
779779
.then(done);
780780
});
781781

782-
it('@flaky should resize in both direction in a grid when responsive: true', function(done) {
782+
it('should resize in both direction in a grid when responsive: true', function(done) {
783783
var numCols = 2;
784784
var numRows = 2;
785785
parent.style.display = 'grid';
@@ -793,7 +793,7 @@ describe('config argument', function() {
793793
.then(done);
794794
});
795795

796-
it('@flaky should provide a fixed non-zero width/height when autosize/responsive: true and container\' size is zero', function(done) {
796+
it('should provide a fixed non-zero width/height when autosize/responsive: true and container\' size is zero', function(done) {
797797
fillParent(1, 1, function() {
798798
this.style.display = 'inline-block';
799799
this.style.width = null;
@@ -821,7 +821,7 @@ describe('config argument', function() {
821821

822822
// The following test is to guarantee we're not breaking the existing (although maybe not ideal) behaviour.
823823
// In a future version, one may prefer responsive/autosize:true winning over an explicit width/height when embedded in a webpage.
824-
it('@flaky should use the explicitly provided width/height even if autosize/responsive:true', function(done) {
824+
it('should use the explicitly provided width/height even if autosize/responsive:true', function(done) {
825825
fillParent(1, 1, function() {
826826
this.style.width = '1000px';
827827
this.style.height = '500px';

‎test/jasmine/tests/draw_newshape_test.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1089,7 +1089,7 @@ describe('Activate and edit editable shapes', function() {
10891089
afterEach(destroyGraphDiv);
10901090

10911091
['mouse'].forEach(function(device) {
1092-
it('@flaky reactangle using ' + device, function(done) {
1092+
it('reactangle using ' + device, function(done) {
10931093
var i = 0; // shape index
10941094

10951095
Plotly.newPlot(gd, {
@@ -1224,7 +1224,7 @@ describe('Activate and edit editable shapes', function() {
12241224
.then(done);
12251225
});
12261226

1227-
it('@flaky circle using ' + device, function(done) {
1227+
it('circle using ' + device, function(done) {
12281228
var i = 1; // shape index
12291229

12301230
Plotly.newPlot(gd, {
@@ -1281,7 +1281,7 @@ describe('Activate and edit editable shapes', function() {
12811281
.then(done);
12821282
});
12831283

1284-
it('@flaky closed-path using ' + device, function(done) {
1284+
it('closed-path using ' + device, function(done) {
12851285
var i = 2; // shape index
12861286

12871287
Plotly.newPlot(gd, {
@@ -1326,7 +1326,7 @@ describe('Activate and edit editable shapes', function() {
13261326
.then(done);
13271327
});
13281328

1329-
it('@flaky bezier curves using ' + device, function(done) {
1329+
it('bezier curves using ' + device, function(done) {
13301330
var i = 5; // shape index
13311331

13321332
Plotly.newPlot(gd, {
@@ -1371,7 +1371,7 @@ describe('Activate and edit editable shapes', function() {
13711371
.then(done);
13721372
});
13731373

1374-
it('@flaky multi-cell path using ' + device, function(done) {
1374+
it('multi-cell path using ' + device, function(done) {
13751375
var i = 6; // shape index
13761376

13771377
Plotly.newPlot(gd, {

‎test/jasmine/tests/polar_test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ describe('Test polar interactions:', function() {
908908
.then(done);
909909
});
910910

911-
it('@flaky should respond to drag interactions on plot area', function(done) {
911+
it('should respond to drag interactions on plot area', function(done) {
912912
var fig = Lib.extendDeep({}, require('@mocks/polar_scatter.json'));
913913

914914
// to avoid dragging on hover labels

0 commit comments

Comments
 (0)