Skip to content

Commit 95c602e

Browse files
committed
last version , we display by order only .
add somes text traces into the baseline test
1 parent 987e6cd commit 95c602e

File tree

3 files changed

+26
-34
lines changed

3 files changed

+26
-34
lines changed

src/traces/scattergl/index.js

+16-34
Original file line numberDiff line numberDiff line change
@@ -261,35 +261,23 @@ function sceneUpdate(gd, subplot) {
261261
var i;
262262
for(i = 0; i < scene.count; i++) {
263263
if(scene.fill2d && scene.fillOptions[i]) {
264-
// must do all fills first
265264
scene.fill2d.draw(i);
266-
if(scene.line2d && scene.lineOptions[i]) {
267-
scene.line2d.draw(i);
268-
if(scene.error2d && scene.errorXOptions[i]) {
269-
scene.error2d.draw(i);
270-
}
271-
if(scene.error2d && scene.errorYOptions[i]) {
272-
scene.error2d.draw(i + scene.count);
273-
}
274-
}
275-
if(scene.scatter2d && scene.markerOptions[i] && (!scene.selectBatch || !scene.selectBatch[i])) {
276-
// traces in no-selection mode
277-
scene.scatter2d.draw(i);
278-
}
279-
} else {
280-
if(scene.line2d && scene.lineOptions[i]) {
281-
scene.line2d.draw(i);
282-
}
283-
if(scene.error2d && scene.errorXOptions[i]) {
284-
scene.error2d.draw(i);
285-
}
286-
if(scene.error2d && scene.errorYOptions[i]) {
287-
scene.error2d.draw(i + scene.count);
288-
}
289-
if(scene.scatter2d && scene.markerOptions[i] && (!scene.selectBatch || !scene.selectBatch[i])) {
290-
// traces in no-selection mode
291-
scene.scatter2d.draw(i);
292-
}
265+
}
266+
if(scene.line2d && scene.lineOptions[i]) {
267+
scene.line2d.draw(i);
268+
}
269+
if(scene.error2d && scene.errorXOptions[i]) {
270+
scene.error2d.draw(i);
271+
}
272+
if(scene.error2d && scene.errorYOptions[i]) {
273+
scene.error2d.draw(i + scene.count);
274+
}
275+
if(scene.scatter2d && scene.markerOptions[i] && (!scene.selectBatch || !scene.selectBatch[i])) {
276+
// traces in no-selection mode
277+
scene.scatter2d.draw(i);
278+
}
279+
if(scene.glText[i] && scene.textOptions[i]) {
280+
scene.glText[i].render();
293281
}
294282
}
295283

@@ -299,12 +287,6 @@ function sceneUpdate(gd, subplot) {
299287
scene.scatter2d.draw(scene.unselectBatch);
300288
}
301289

302-
for(i = 0; i < scene.count; i++) {
303-
if(scene.glText[i] && scene.textOptions[i]) {
304-
scene.glText[i].render();
305-
}
306-
}
307-
308290
scene.dirty = false;
309291
};
310292

4.83 KB
Loading

test/image/mocks/gl2d_order_error.json

+10
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@
88
"marker": {"color": "#800"},"line": {"color": "#400"}
99
},{
1010
"type": "scattergl",
11+
"y": [3, 2, 1, 1], "mode":"text","xaxis": "x", "yaxis": "y" ,
12+
"text": ["A","B","C","D"],
13+
"textfont": { "size": [ 30, 20 , 30 , 30 ] }
14+
},{
15+
"type": "scattergl",
1116
"y": [1, 4, 0, 3],
1217
"fillcolor":"#282","fill": "tozeroy", "xaxis": "x", "yaxis": "y" ,
1318
"error_x": {"value": 0.4, "type": "constant","color":"#028"},
@@ -22,6 +27,11 @@
2227
"marker": {"color": "#088"},"line": {"color": "#044"}
2328
},{
2429
"type": "scatter",
30+
"y": [3, 2, 1, 1], "mode":"text","xaxis": "x2", "yaxis": "y2" ,
31+
"text": ["A","B","C","D"],
32+
"textfont": { "size": [ 30, 20 , 30 , 30 ] }
33+
},{
34+
"type": "scatter",
2535
"y": [1, 4, 0, 3],
2636
"fillcolor":"#882","fill": "tozeroy", "xaxis": "x2", "yaxis": "y2" ,
2737
"error_x": {"value": 0.4, "type": "constant","color":"#028"},

0 commit comments

Comments
 (0)