eliminate calc.js loop based on commit from @etpinard

778ebb8

Author: monfera

src/traces/parcoords/calc.js

@@ -14,22 +14,6 @@ var Lib = require('../../lib');
 
 
 module.exports = function calc(gd, trace) {
-    var inputDimensions = trace.dimensions,
-        dimensions = [];
-    for(var i = 0; i < inputDimensions.length; i++) {
-
-        dimensions.push({
-            range: inputDimensions[i].range,
-            constraintrange: inputDimensions[i].constraintrange,
-            tickvals: inputDimensions[i].tickvals,
-            ticktext: inputDimensions[i].ticktext,
-            tickformat: inputDimensions[i].tickformat,
-            visible: inputDimensions[i].visible,
-            label: inputDimensions[i].label,
-            values: inputDimensions[i].values
-        });
-    }
-
     var cs = !!trace.line.colorscale && Lib.isArray(trace.line.color);
     var color = cs ? trace.line.color : Array.apply(0, Array(trace.dimensions.reduce(function(p, n) {return Math.max(p, n.values.length);}, 0))).map(function() {return 0.5;});
     var cscale = cs ? trace.line.colorscale : [[0, trace.line.color], [1, trace.line.color]];
@@ -43,7 +27,7 @@ module.exports = function calc(gd, trace) {
 
     return [{
         domain: trace.domain,
-        dimensions: dimensions,
+        dimensions: trace.dimensions,
         line: trace.line
     }];
 };

src/traces/parcoords/defaults.js

@@ -14,7 +14,7 @@ var hasColorscale = require('../../components/colorscale/has_colorscale');
 var colorscaleDefaults = require('../../components/colorscale/defaults');
 var maxDimensionCount = require('./constants').maxDimensionCount;
 
-var handleLineDefaults = function lineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
+function handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
 
     coerce('line.color', defaultColor);
     coerce('line.colorscale');
@@ -25,7 +25,7 @@ var handleLineDefaults = function lineDefaults(traceIn, traceOut, defaultColor,
     else {
         coerce('line.color', defaultColor);
     }
-};
+}
 
 function dimensionsDefaults(traceIn, traceOut) {
     var dimensionsIn = traceIn.dimensions || [],