use styleOnSelect for scatter[polar]gl and splom

... instead of 'style', for consistency. Other _module.style
    in the traces/ get called during Plots.style, something
    we don't want to do in regl traces, to avoid double-drawing.

Author: etpinard

src/traces/scattergl/index.js

@@ -893,9 +893,7 @@ function selectPoints(searchInfo, selectionTester) {
     return selection;
 }
 
-function style(gd, cds) {
-    if(!cds) return;
-
+function styleOnSelect(gd, cds) {
     var stash = cds[0][0].t;
     var scene = stash._scene;
 
@@ -957,7 +955,7 @@ module.exports = {
     calc: calc,
     plot: plot,
     hoverPoints: hoverPoints,
-    style: style,
+    styleOnSelect: styleOnSelect,
     selectPoints: selectPoints,
 
     sceneOptions: sceneOptions,

src/traces/scatterpolargl/index.js

@@ -183,7 +183,7 @@ module.exports = {
     calc: calc,
     plot: plot,
     hoverPoints: hoverPoints,
-    style: ScatterGl.style,
+    styleOnSelect: ScatterGl.styleOnSelect,
     selectPoints: ScatterGl.selectPoints,
 
     meta: {

src/traces/splom/index.js

@@ -424,9 +424,7 @@ function selectPoints(searchInfo, selectionTester) {
     return selection;
 }
 
-function style(gd, cds) {
-    if(!cds) return;
-
+function styleOnSelect(gd, cds) {
     var fullLayout = gd._fullLayout;
     var cd0 = cds[0];
     var scene0 = fullLayout._splomScenes[cd0[0].trace.uid];
@@ -479,7 +477,7 @@ module.exports = {
     plot: plot,
     hoverPoints: hoverPoints,
     selectPoints: selectPoints,
-    style: style,
+    styleOnSelect: styleOnSelect,
 
     meta: {
         description: [

test/jasmine/tests/splom_test.js

@@ -1087,20 +1087,20 @@ describe('Test splom select:', function() {
 
         Plotly.newPlot(gd, fig).then(function() {
             // 'scattergl' trace module
-            spyOn(gd._fullLayout._modules[0], 'style').and.callFake(function() {
+            spyOn(gd._fullLayout._modules[0], 'styleOnSelect').and.callFake(function() {
                 cnt++;
                 scatterGlCnt = cnt;
             });
             // 'splom' trace module
-            spyOn(gd._fullLayout._modules[1], 'style').and.callFake(function() {
+            spyOn(gd._fullLayout._modules[1], 'styleOnSelect').and.callFake(function() {
                 cnt++;
                 splomCnt = cnt;
             });
         })
         .then(function() { return _select([[20, 395], [195, 205]]); })
         .then(function() {
-            expect(gd._fullLayout._modules[0].style).toHaveBeenCalledTimes(1);
-            expect(gd._fullLayout._modules[1].style).toHaveBeenCalledTimes(1);
+            expect(gd._fullLayout._modules[0].styleOnSelect).toHaveBeenCalledTimes(1);
+            expect(gd._fullLayout._modules[1].styleOnSelect).toHaveBeenCalledTimes(1);
 
             expect(cnt).toBe(2);
             expect(splomCnt).toBe(1, 'splom redraw before scattergl');